DDIR Corgi chunks: consolidate uniform timestamps without sorting times - #909
Closed
frankmcsherry wants to merge 1 commit into
Closed
frankmcsherry wants to merge 1 commit into
frankmcsherry wants to merge 1 commit into
Conversation
When every update in a chunk carries the same timestamp, consolidate directly within equal (key, value) classes, preserving addition order, instead of sorting times within each class. Chunks with varying times keep the existing path. Co-Authored-By: Astra (OpenAI Codex) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
frankmcsherry
force-pushed
the
ddir-uniform-consolidation
branch
from
September 28, 2026 23:47
1a1c6a3 to
88299bd
Compare
Member
Author
|
Rebased onto master-next after #908 (88299bd). The uniform-time shortcut now walks #908's equality-label runs, so it no longer builds its own adjacent comparison, and it gathers the payload once from the surviving source rows as #908 does. |
Member
Author
|
Closing as "not obviously great" and "would be done differently atop #908 anyhow". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chunk consolidation sorts by time within each equal
(key, value)run. When every row in the chunk has the same timestamp, there is nothing to sort. The newColTimes::is_uniformdetects that case (it checks all coordinates, including zero-width times), and consolidation then sums the diffs of each equal run directly. Chunks whose times vary take the existing path. Three files, +51 lines, including tests for uniformity and cancellation.Measured on SCC, the worldgen tour, and the stock AoC runner. Three paired runs each, order reversed in the middle run, M4 release build:
The gains are small. SCC peak at 4 workers falls 9.0% in every pair, with ranges that do not overlap. In worldgen, on top of other changes, the tour is 1.7–1.9% faster at 1, 3 and 4 workers.
Unexplained validation failure. In one early 4-worker AoC run with this change, the runner reported day02 part 1 as an empty string (8 was expected). That runner mixed stdout and stderr and did not keep the raw output, so the cause cannot be found now. No wrong number was ever reported. We then ran the focused case 4,600 times, on base and with this change, with stdout and stderr both mixed and separate. None of those runs failed. With output captured properly, every later paired run passed all 33 answers at 1 and 4 workers. We have seen stdout and inspect output interleave in a baseline server session, so a capture problem is a plausible cause, but it is not proven.
Tests.
cargo test --release -p interactive: 106 passed, 5 ignored (all ignored before this change too). The supported sessions and the graph outputs match on both backends.This PR and the sort-labels PR edit the same function. They were measured separately and do not depend on each other.
Measurements and the port are by Astra (OpenAI Codex). I re-ran the tests on master-next 9cfc909.
🤖 Generated with Claude Code