DDIR Corgi join/arrange: four copy removals - #911
Merged
Merged
Conversation
The join's comparison views gathered temporary key columns before comparing them. Borrow the chunk's u64 lanes with absolute row indices instead; the owning chunks outlive the views. The structural fallback and the output gathers are unchanged. Adds an oracle against structural row comparison for sparse and skipped ranges. Co-Authored-By: Astra (OpenAI Codex) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
A compound key's arrangement carries an identifier (hash) column that join output projections drop. Borrow the declared key before gathering output instead of gathering the presented key and discarding its hash. Presented keys stay for matching and collision checks. Co-Authored-By: Astra (OpenAI Codex) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The chunker already took ownership of payload columns, but copied times and diffs even when starting an empty batch. Swap the first input's owned buffers into the empty accumulator and hand its empty buffers back to the sender; later blocks append as before. Adds an oracle over single and multiple block flushes, mixed PointStamp widths, and cancellation. Co-Authored-By: Astra (OpenAI Codex) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The survey result is not read once output begins, and the source/offset indices are not read once the surviving suffix is gathered. Drop them at their last use rather than at the end of the merge, so they no longer overlap the output's allocations. Output and API unchanged. Co-Authored-By: Astra (OpenAI Codex) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four small changes that remove a copy or shorten a buffer's lifetime in the Corgi join and arrangement path. There is one commit each; each can be reviewed or dropped on its own.
u64lanes with absolute row indices. Adds an oracle against structural row comparison.2 files, +135 −65.
The case for this is less copying and less held memory, not speed. Base is master-next 5fd3ecc and the candidate is this branch. Three pairs, order reversed in the middle pair, on an M4. The tour and SCC programs have their
inspects removed. Medians:Earlier measurements on the worldgen DDIR tour:
Tests.
cargo test --release -p interactive: 114 passed, 5 ignored (all ignored before this change too). All 33 AoC answers are checked on every run, and every timed tour and SCC output matches an oracle agreed by both backends.The changes are by Astra (OpenAI Codex). I cherry-picked them onto master-next, resolved a test-only conflict with #908, and ran these measurements.
🤖 Generated with Claude Code