Repository navigation
fix(backend): return Unit from async refreshCountryUsage - #616
Merged
Merged
Conversation
SchedulingService is annotated with @async, which only supports void or Future return types. The expression body of refreshCountryUsage returned the Int from CountryUsageService.refresh(), so every run failed with "Invalid return type for async method". Add a test that checks all scheduled methods return void or Future. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The edge image from master logs this error each time the country usage refresh runs:
SchedulingServiceis annotated@Asyncat class level.refreshCountryUsage()(added in #606) had an expression body, so it returned theIntfromCountryUsageService.refresh(). Spring rejects that before the task runs, so country usage was never refreshed.Fix
Unit/void. No other scheduled method was affected.SchedulingServiceTest, which uses reflection to check that every@Scheduledmethod returnsvoidorFuture. I confirmed it fails against the old code.🤖 Generated with Claude Code