Skip to content

Centralize Rust build logic into RustBuild.cmake #8536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bdash wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Centralize Rust build logic into RustBuild.cmake #8536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 1 addition & 20 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,17 +41,6 @@ target_include_directories(binaryninjaapi

target_link_libraries(binaryninjaapi PUBLIC binaryninjabase)

# Store path to user plugin dir
if(WIN32)
set(plugin_dir "$ENV{APPDATA}\\Binary Ninja\\plugins")
elseif(APPLE)
set(plugin_dir "$ENV{HOME}/Library/Application Support/Binary Ninja/plugins")
else()
set(plugin_dir "$ENV{HOME}/.binaryninja/plugins")
endif()
set(BN_USER_PLUGINS_DIR "${plugin_dir}" CACHE PATH "Path to Binary Ninja user plugins")
message(STATUS "Binary Ninja User Plugins Dir: ${BN_USER_PLUGINS_DIR}")

find_package(BinaryNinjaCore)
if(BinaryNinjaCore_FOUND)
target_link_libraries(binaryninjaapi PUBLIC ${BinaryNinjaCore_LIBRARIES})
Expand Down Expand Up @@ -120,15 +109,7 @@ if(NOT HEADLESS)
endif()

function(bn_install_plugin target)
if(WIN32)
set(plugin_dir "$ENV{APPDATA}\\Binary Ninja\\plugins")
elseif(APPLE)
set(plugin_dir "$ENV{HOME}/Library/Application Support/Binary Ninja/plugins")
else()
set(plugin_dir "$ENV{HOME}/.binaryninja/plugins")
endif()
set(BN_USER_PLUGINS_DIR "${plugin_dir}" CACHE PATH "Path to Binary Ninja user plugins")

# BN_USER_PLUGINS_DIR is set by FindBinaryNinjaCore.cmake
if(NOT BN_INTERNAL_BUILD)
if(WIN32)
install(TARGETS ${target} RUNTIME
Expand Down
Loading
Loading