Repository navigation
simple-git-4 - #825
Merged
Merged
simple-git-4#825
Conversation
…s let through (simple-git-4) The dependency audit failed every pull request: two critical advisories in simple-git <= 4.0.1 (GHSA-v5rq-49vh-5v5c, GHSA-x6jw-m9v5-85vh), fixed only in 4.0.2. simple-git 4 strips every GIT_ variable and a few others from the environment of the git it starts, which would take away the askpass helper and SSH command a person set up to reach their remote; an SSH remote then waits on the real ssh until killed. Git is now opened through one function, openGit(cwd), that lets through GIT_ASKPASS, SSH_ASKPASS, GIT_SSH, GIT_SSH_COMMAND, GIT_SSH_VARIANT and GIT_TERMINAL_PROMPT, and nothing else that is guarded. Test fixtures name the author and committer variables their commits set. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
VeryComplexAndLongName
added a commit
that referenced
this pull request
Oct 6, 2026
Brings in simple-git 4.0.2 (#825), which the dependency audit needs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simple-git-4
The dependency audit started failing every pull request on 2026-10-06: two critical advisories in
simple-git<= 4.0.1 (GHSA-v5rq-49vh-5v5c, GHSA-x6jw-m9v5-85vh), fixed only in 4.0.2. This repository was on 3.x.coreandcli;npm audit --omit=dev --audit-level=highfinds 0 vulnerabilities.GIT_variable (andEDITOR,PAGER,SSH_ASKPASS,VISUAL,PREFIX) from the git it starts. That would take away the askpass helper VS Code provides and a person's SSH command; measured here, an SSH remote then waits on the realsshuntil killed.openGit(cwd)(git-client.ts) replaces everysimpleGit(cwd)and lets through onlyGIT_ASKPASS,SSH_ASKPASS,GIT_SSH,GIT_SSH_COMMAND,GIT_SSH_VARIANT,GIT_TERMINAL_PROMPT; every other guarded variable stays away from git.Checks
git-client.test.ts(real git):GIT_SSH_COMMANDreaches git,GIT_EDITORdoes not; fails without the allowance.openspec validate --strict; merge gate with the absolute worktree path: ok.After this merges, re-running the audit on #824 turns it green.
🤖 Generated with Claude Code