Improve fallback names for imported and exported items - #9079
Open
GtechGovind wants to merge 2 commits into
Open
Improve fallback names for imported and exported items#9079GtechGovind wants to merge 2 commits into
GtechGovind wants to merge 2 commits into
Conversation
Member
|
(looks like there are test failures) |
tlively
reviewed
Sep 9, 2026
Comment on lines
+2790
to
+2792
| memoryNames, | ||
| numImports + i, | ||
| getFallbackName(memoryExportNames, numImports + i, makeName("", i)), |
Member
There was a problem hiding this comment.
It would be good to clean up the duplication of passing in memoryNames and numImports + i in two places here.
Share export-name selection with getOrMakeName to avoid repeating the name maps and absolute indices. Keep generated names for empty exports so disassembly remains valid text. Cover first-export preference, name collisions, and empty-export roundtrips. Update the affected name-only test expectations while preserving text/debug paths and metadata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2504
Summary
Testing
cmake --build build --target wasm-as wasm-dis wasm-opt -j4PATH=/tmp/binaryen-sep6-venv/bin:$PATH /tmp/binaryen-sep6-venv/bin/python build/bin/binaryen-lit test/lit/binary -j4(21 passed)