Conversation
kripken
requested review from
stevenfontanella
and removed request for
a team
September 17, 2026 18:59
tlively
approved these changes
Sep 17, 2026
Comment on lines
+558
to
+559
| // unreachable one). In that case, the replacement must still validate | ||
| // as if it were written, so we must fix it up below. |
Member
There was a problem hiding this comment.
Maybe we could relax this in the validator. I don't think we're consistent about how we enforce requirements on non-unreachable children of unreachable expressions.
Member
Author
There was a problem hiding this comment.
Hmm, that might be another option. Though I think stricter validation (like we have now) is generally the thing to aim for?
Member
Author
There was a problem hiding this comment.
(Agree the current validator might not be consistent on this, though...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the replacement value is not unreachable, we still need to fix it up.
Also add TODOs for StructWait here and in other passes (which will
have similar issues). cc @stevenfontanella who I think added that
class.