Skip to content

Comments/Questions #276

Description

@rossberg

I finally did an end-to-end read of all (well, most of) the docs in this repo. Since GH doesn't offer a means to comment on committed files, I created a dummy repo with a dummy PR of the entire content here and left my comments & questions there. Hope that indirection works well enough. :)

Overall, this looks great. I found the explainer particularly helpful and very well-written.

Happy to open individual issues for some of my comments/suggestions if they turn out to be relevant.

Activity

  1. lukewagner commented on Nov 29, 2023

    @lukewagner
    Member

    Awesome, thanks so much! I'll definitely go through the comments and either turn them into PRs or ask questions here or open new issues, as appropriate.

  2. added a commit that references this issue on Apr 11, 2024
  3. lukewagner commented on Apr 11, 2024

    @lukewagner
    Member

    Oops, this fell off my radar, but I started going through all the comments just now. I started with a first pass that simply fixes typos in this commit. For the rest, I'll submit some PRs so they can be reviewed.

  4. lukewagner commented on Apr 13, 2024

    @lukewagner
    Member

    Ok, I went through all the comments and either replied inline or folded the feedback into #339 or #341. Happy to discuss more inline in those comment threads or on the above PRs or here.

  5. rossberg commented on Apr 16, 2024

    @rossberg
    MemberAuthor

    Thanks, I left a few more replies.

  6. lukewagner commented on Apr 30, 2024

    @lukewagner
    Member

    (Also filed #351.)

  7. lukewagner commented on May 6, 2024

    @lukewagner
    Member

    Ok, with #353 filed, I think I've gone through all the comments. Thanks a lot for all the feedback and suggestions!

  8. lukewagner commented on May 8, 2024

    @lukewagner
    Member

    Great, thanks for filing #356 for discussion. I'll close this issue b/c I think that's everything, but feel free to reopen if there's anything missing, or file new issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions