Conversation
The plugin carries a clearance_scope option, passes it to the client as data-scope, and described it as "optional scope passed to the clearance client (advanced)". Nothing enforces it: a clearance token is bound to the organization, and no validator reads a token's scope. Comments only. The option keeps being read and emitted, so a site that set it behaves exactly as before. Refs WebDecoy/app#1122.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while closing WebDecoy/app#1122, which removed
data-scopefrom the customer-facing docs because nothing enforces it.The plugin still carries
clearance_scope, emits it asdata-scope, and its comment read "Optional scope passed to the clearance client (advanced)" — which reads like it narrows where a token is valid. It does not: a clearance token is bound to the organization, and no validator reads a token's scope.Comments only. The option is still read, sanitized and emitted, so a site that set it behaves exactly as before. There is no settings field for it, so nothing in the admin UI changes either.
No release needed; it rides along with the next one.
php -lclean, phpcs unchanged, phpstan[OK] No errors(with--memory-limit=1G; the default 128M crashes the worker on this repo regardless of this change).