feat: possible second implementation of the new structure system by noone-075 · Pull Request #24 · WebMCDevelopment/wlib

noone-075 · 2026-09-05T17:30:38Z

the old API is fully usable in api.structure.* but deprecated and mark for removal
the new API is located in api.structures.* and it would be the new way to create structures
the new API works with 2 types of structures: LocatedStructure and RelativeStructure
- LocatedStructure is a structure that is generated at a specific location and it can be placed without specifying a location, it is already located
- RelativeStructure is a structure that is generated relative to a location and it can be placed to any location, it is not located
each of them uses a PlacebleStructure (either LocatedPlacebleStructure or RelativePlacebleStructure) to build the structure and place it.
to make a new Structure, you need to extend either of them, and implement the build() method to return the correct type of PlacebleStructure
they use custom placeble blocks (LocatedBlock, RelativeBlock), they can also override the place function for custom behavior
then implementing the GenerableStructure interface is optional, it allows the structure to have the function needed to be generated in the world, if used by a chunk generator.

THIS IS NOT A FINAL IMPLEMENTATION, IT IS STILL IN DEVELOPMENT AND MAY CHANGE IN THE FUTURE.

- the old API is fully usable in api.structure.* but deprecated and mark for removal - the new API is located in api.structures.* and it would be the new way to create structures - the new API works with 2 types of structures: LocatedStructure and RelativeStructure - LocatedStructure is a structure that is generated at a specific location and it can be placed without specifying a location, it is already located - RelativeStructure is a structure that is generated relative to a location and it can be placed to any location, it is not located - each of them uses a PlacebleStructure (either LocatedPlacebleStructure or RelativePlacebleStructure) to build the structure and place it. - to make a new Structure, you need to extend either of them, and implement the build() method to return the correct type of PlacebleStructure - they use custom placeble blocks (LocatedBlock, RelativeBlock), they can also override the place function for custom behavior - then implementing the GenerableStructure interface is optional, it allows the structure to have the function needed to be generated in the world, if used by a chunk generator. THIS IS NOT A FINAL IMPLEMENTATION, IT IS STILL IN DEVELOPMENT AND MAY CHANGE IN THE FUTURE.

colbster937

i have requested all the changes i want (i'll fix what i can). i would also like to keep the package the same as the old api as to keep it consistent (singular words, not plural).

colbster937 · 2026-09-05T19:52:05Z

it would also be a good idea to rename some classes (e.g. "Block") to not be the same as a bukkit class name, so they can be used in classes that already import bukkit classes

noone-075 · 2026-09-06T09:42:35Z

it would also be a good idea to rename some classes (e.g. "Block") to not be the same as a bukkit class name, so they can be used in classes that already import bukkit classes

What about, it might be redundant but: PlaceableBlock.

- introduce the new abstract structure base and instance registry - update located/relative/placeable structure types - remove legacy structure entry and align command/test usages - added new exemple of structure

noone-075 · 2026-09-09T20:17:59Z

i think its finished tell me if it is then i wont change it until merge with upstream

colbster937 · 2026-09-09T20:21:13Z

i have requested all the changes i want (i'll fix what i can). i would also like to keep the package the same as the old api as to keep it consistent (singular words, not plural).

resurfacing this 4 day old comment

colbster937 · 2026-09-14T12:28:51Z

i have requested all the changes i want (i'll fix what i can). i would also like to keep the package the same as the old api as to keep it consistent (singular words, not plural).

resurfacing this 4 day old comment

resurfacing me resurfacing this comment 5 days ago

noone-075 · 2026-09-14T15:45:52Z

i have requested all the changes i want (i'll fix what i can). i would also like to keep the package the same as the old api as to keep it consistent (singular words, not plural).

resurfacing this 4 day old comment

resurfacing me resurfacing this comment 5 days ago

the package is api.structure.* and internal.structure.*
i already fixed that
(did it directly in the merge)

noone-075 · 2026-09-14T15:48:57Z

notice im not done reorganizing but its near to be completed

colbster937

sorry if this is coming off as rude, but what exactly is the usecase for this major refactor? i get the ability to use it in a chunkgenerator, but i also liked the simplicity of the previous impl. it was just an idea i came up with while walking to class and implemented it in a simple way so that it would be easy to use.

colbster937 · 2026-09-14T20:15:33Z

+    if (material == null) {
+      return;
+    }


flip the condition and dont return

colbster937 · 2026-09-14T20:15:53Z

+    if (chunk instanceof org.bukkit.Chunk liveChunk) {
+      if (loc.getWorld() == liveChunk.getWorld()
+          && loc.getBlockX() >> 4 == liveChunk.getX()
+          && loc.getBlockZ() >> 4 == liveChunk.getZ()) {
+        this.place(loc);
+      }
+      return;
+    }


flip the condition and dont return

colbster937 · 2026-09-14T20:16:06Z

+  }
+
+  protected void place(Location loc, Object chunk) {
+    if (chunk instanceof org.bukkit.Chunk liveChunk) {


import the class, dont use the fqpn

colbster937 · 2026-09-14T20:16:12Z

+      if (loc.getBlockX() >> 4 != builderChunk.x()
+          || loc.getBlockZ() >> 4 != builderChunk.z()) {
+        return;
+      }


flip the condition and dont return

colbster937 · 2026-09-14T20:16:16Z

+      if (material == null) {
+        return;
+      }


flip the condition and dont return

colbster937 · 2026-09-14T20:31:29Z

+  public static BaseStructure getTestStructure(Class<?> clazz) {
+    for (BaseStructure structure : getStructures()) {
+      if (structure.getClass().equals(clazz)) {
+        return structure;
+      }
+    }
+
+    return null;


the point of the reflection method was to avoid repeating code like this

colbster937 · 2026-09-14T20:31:39Z

  }

  public static Set<String> getStructureNames() {
-    final Set<String> names = new HashSet<>();


should be final

colbster937 · 2026-09-14T20:32:07Z

-/dependency-reduced-pom.xml
+/dependency-reduced-pom.xml
+
+.vscode


.vscode should be with the existing directory ignores at the top

colbster937 · 2026-09-14T20:32:31Z

+      - id: vars
+        run: |
+          echo "JAVA=$(mvn help:evaluate -Dexpression=maven.compiler.release -q -DforceStdout)" >> "$GITHUB_OUTPUT"
+          echo "VERSION=$(mvn help:evaluate -Dexpression=project.version -q -DforceStdout)" >> "$GITHUB_OUTPUT"


should be "VERS", not "VERSION"

colbster937 · 2026-09-14T20:33:08Z

+  public static void sendUnknownCommandMessage(CommandSender sender) {
+    boolean bool = true;
+
+    final Class<?> clazz = MirrorSafe.getClass("org.spigotmc.SpigotConfig");
+    if (clazz != null) {
+      final String msg = MirrorSafe.getFieldValue(clazz, "unknownCommandMessage");
+      if (msg != null) {
+        sender.sendMessage(msg);
+        bool = false;
+      }
+    }
+
+    if (bool) {
+      sender.sendMessage(ChatColor.RED + "Unknown command.");
+    }
+  }
+
+  public static void sendOnlyPlayersMessage(CommandSender sender) {
+    sender.sendMessage(ChatColor.RED + "This command can only be used by players.");
+  }


static methods go under instance methods

noone-075 · 2026-09-15T09:00:01Z

sorry if this is coming off as rude, but what exactly is the usecase for this major refactor? i get the ability to use it in a chunkgenerator, but i also liked the simplicity of the previous impl. it was just an idea i came up with while walking to class and implemented it in a simple way so that it would be easy to use.

the goals are:

being able to generate the structure depending on where it is located (AbsoluteStructure).
being able to create a structure that remains the same regardless of the location where it is placed (RelativeStructure), already existed.
being able to place it in ChunkGenerator.
having generation tools (GenerableStructure).

colbster937 · 2026-09-15T12:10:22Z

I don't get what you mean by the 1st, 2nd, and 3rd, can you elaborate?

noone-075 · 2026-09-15T15:52:11Z

look at CoordinateStructure in internal. this structure places black and white concrete depending on the position the structure was placed on (it encodes in binary the coords), im using the AbsoluteStructure to be able to change how the structure is generated, depending on the location, this allows for complex randomnized structure like in vanilla generation. while the RelativeStructure is more like a schematic of a structure you can place anywhere in the world. if you place it at 0,0 or at 10000,10000 it will be the exact same.
The number 3 is for automatic generation in the world, this allow to generate the structure chunk by chunk either when loading for the first time the chunk. or to generate it with a chunkGenerator.
MyStructure.place(CenterLocationOfTheStructure, ChunkToPlaceIn) should always place the same block at the same place this allow for custom generation for big structures that extend in multiple chunks

colbster937 · 2026-09-15T16:42:46Z

sorry, i meant 1st, 2nd, and 4th, not 3rd

noone-075 marked this pull request as ready for review September 5, 2026 17:30

noone-075 mentioned this pull request Sep 5, 2026

Structure API revamp #20

Closed

colbster937 self-assigned this Sep 5, 2026

colbster937 self-requested a review September 5, 2026 19:09

colbster937 requested changes Sep 5, 2026

View reviewed changes

colbster937 self-requested a review September 5, 2026 19:33

colbster937 reviewed Sep 5, 2026

View reviewed changes

Comment thread src/main/java/xyz/webmc/wlib/internal/structure/HerobrineShrineTestStructure.java

Comment thread src/main/java/xyz/webmc/wlib/internal/structure/RickQRCodeTestSchemStructure.java

chore: fix issues

5419c65

noone-075 commented Sep 6, 2026

View reviewed changes

Comment thread src/main/java/xyz/webmc/wlib/api/structures/blocks/LocatedBlock.java Outdated

noone-075 commented Sep 6, 2026

View reviewed changes

Comment thread src/main/java/xyz/webmc/wlib/api/structures/blocks/RelativeBlock.java Outdated

feat: made blocks not final + rename Block to PlaceableBlock

c58e3b6

noone-075 force-pushed the wait-for-it branch from 39388bb to c58e3b6 Compare September 6, 2026 13:52

fix: fixed everything that wasnt fixed

c885b6e

noone-075 requested a review from colbster937 September 7, 2026 05:46

colbster937 reviewed Sep 7, 2026

View reviewed changes

noone-075 commented Sep 8, 2026

View reviewed changes

Comment thread src/main/java/xyz/webmc/wlib/internal/structures/HerobrineShrineTestStructure.java Outdated

feat: redesign structure API and add instance management

54aeaba

- introduce the new abstract structure base and instance registry - update located/relative/placeable structure types - remove legacy structure entry and align command/test usages - added new exemple of structure

noone-075 requested a review from colbster937 September 9, 2026 20:03

feat: add chunk generation helpers

aaa796b

colbster937 requested changes Sep 9, 2026

View reviewed changes

colbster937 and others added 5 commits September 9, 2026 15:31

Merge branch 'main' into wait-for-it

32b7165

Merge remote-tracking branch 'upstream/main' into wait-for-it

8b5fcac

fix: remove useless SuppressWarnings

8f9a11a

feat: new workflow to test build

e2ad7e7

fix: make it executable

457f676

feat: added canGenerate(BuilderChunk)

42be90d

noone-075 and others added 2 commits September 14, 2026 19:56

feat: moved to Absolute and other things

d0c64e5

chore: auto-format code

4db647e

colbster937 requested changes Sep 14, 2026

View reviewed changes

Uh oh!

Conversation

noone-075 commented Sep 5, 2026

Uh oh!

colbster937 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

colbster937 commented Sep 5, 2026

Uh oh!

noone-075 commented Sep 6, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

noone-075 commented Sep 9, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

colbster937 commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

colbster937 commented Sep 14, 2026

Uh oh!

noone-075 commented Sep 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

noone-075 commented Sep 14, 2026

Uh oh!

colbster937 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

noone-075 commented Sep 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

colbster937 commented Sep 15, 2026

Uh oh!

colbster937 commented Sep 9, 2026 •

edited

Loading

noone-075 commented Sep 14, 2026 •

edited

Loading

noone-075 commented Sep 15, 2026 •

edited

Loading