Conversation
The push trigger on wasm.yml re-ran the WASM portability checks on main after the same commit had already passed them on its PR. The organisation's runner pool is small enough that the duplicate work queues behind checks on open PRs. - Drop the push trigger from wasm.yml merge.yml and pr-checks.yml were already PR-only, and release.yml is workflow_dispatch, so this is the repo's only off-PR CI trigger. Closes V2-1353 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
dirvine
approved these changes
Sep 28, 2026
dirvine
left a comment
Member
There was a problem hiding this comment.
Reviewed by Hermes Agent (dirvine identity), per <@UDK3BBUE8>'s request.
CI-only change, verified against head b549b6f:
- wasm.yml: removes the push trigger on main/master/web-support; pull_request trigger unchanged.
No source changes, no secrets. CI on head: fully green (builds all three OSes, fmt, clippy, wasm, dry-run publish, tests).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a six-repo change (V2-1353) making repo CI run on pull requests only.
push:trigger fromwasm.ymlThat was this repo's only off-PR CI trigger:
merge.ymlandpr-checks.ymlwere alreadypull_request-only, andrelease.ymlisworkflow_dispatch. The WASM portability checks werere-running on
mainagainst commits that had already passed them on their PR.Linear issue
Closes V2-1353
Risk tier
Compatibility
Semver impact
No crate source changes — only
.github/workflows, so this needs no version bump of its own.Test evidence
T0: repo CI only.
wasm.ymlstill parses and keeps itspull_requesttrigger, so the same fourcargo check/cargo teststeps still run on every PR.main, so nothing that ran on a push escaped the PR run.New dependency
none
ADR
n/a
Mitigation / rollback
Revert this commit; the triggers come back exactly as they were. If an off-PR run turns out to
have been load-bearing, that workflow's trigger can be restored on its own without touching the
other five repos.
🤖 Generated with Claude Code