Code Modernization: Use the null coalescing operator in wp_get_chromium_major_version() tests - #13469
Open
Soean wants to merge 1 commit into
Open
Conversation
…ium_major_version()` tests. Replaces an `isset()` ternary with the null coalescing operator when reading `$_SERVER['HTTP_USER_AGENT']`. The operator is available since PHP 7.0 and WordPress requires PHP 7.4 or later.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mukeshpanchal27
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests_Media_wpGetChromiumMajorVersion::set_up()stores the original$_SERVER['HTTP_USER_AGENT']value using anisset()ternary that repeats the array access. This replaces it with the null coalescing operator, which is shorter and expresses the same intent.The null coalescing operator is available since PHP 7.0, and WordPress requires PHP 7.4 or later, so no compatibility concerns apply. It is already used widely across the codebase, so this makes the style more consistent.
Follow-up to 62428.
Trac ticket: https://core.trac.wordpress.org/ticket/65819
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.