Skip to content

Code Modernization: Use null coalescing operator in WP_Block_Parser class methods - #13484

Closed
mukeshpanchal27 wants to merge 3 commits into
WordPress:trunkfrom
mukeshpanchal27:fix/use-null-coalescing-1
Closed

Code Modernization: Use null coalescing operator in WP_Block_Parser class methods#13484
mukeshpanchal27 wants to merge 3 commits into
WordPress:trunkfrom
mukeshpanchal27:fix/use-null-coalescing-1

Conversation

@mukeshpanchal27

@mukeshpanchal27 mukeshpanchal27 commented Sep 11, 2026

Copy link
Copy Markdown
Member

Trac ticket: https://core.trac.wordpress.org/ticket/65818

GB WordPress/gutenberg#82763

Use of AI Tools

N/A


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@mukeshpanchal27 mukeshpanchal27 self-assigned this Sep 11, 2026
@github-actions

github-actions Bot commented Sep 11, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props mukesh27, wildworks.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@t-hamano t-hamano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. We should update here as well.

public function add_freeform( $length = null ) {
$length = $length ? $length : strlen( $this->document ) - $this->offset;

Additionally, could you submit a Gutenberg PR? There should be similar sections.

@mukeshpanchal27 mukeshpanchal27 changed the title Code Modernization: Use null coalescing operator in WP_Block_Parser::add_inner_block() Code Modernization: Use null coalescing operator in WP_Block_Parser class methods Sep 11, 2026
wporg-sync pushed a commit that referenced this pull request Sep 11, 2026
Two methods used a ternary that treats a falsy value as not provided even though the parameters accept `0` as valid input, so this switches to the null coalescing operator, which tests only for `null`.

Developed in: #13484

Props mukesh27, wildworks.
See #65818.


git-svn-id: https://develop.svn.wordpress.org/trunk@63601 602fd350-edb4-49c9-b593-d223f7449a82
wporg-sync pushed a commit to WordPress/WordPress that referenced this pull request Sep 11, 2026
Two methods used a ternary that treats a falsy value as not provided even though the parameters accept `0` as valid input, so this switches to the null coalescing operator, which tests only for `null`.

Developed in: WordPress/wordpress-develop#13484

Props mukesh27, wildworks.
See #65818.

Built from https://develop.svn.wordpress.org/trunk@63601


git-svn-id: http://core.svn.wordpress.org/trunk@62777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
@t-hamano

Copy link
Copy Markdown
Contributor

@t-hamano t-hamano closed this Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants