HTML API: Simplify the class_list loop - #8076
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Defer whitespace scanning until class_list() resumes. This avoids scanning a long whitespace suffix when callers stop after a match.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This is a simplification and optimization of the class_list loop based on some work in #7857.
The important change here is that the position (
$at) advances past any whitespace characters before the while condition is checked. The loop never begins at whitespace characters allowing for a few checks to be eliminated and the overall loop logic to be simplificed. Whitespace is skipped before the loop is entered and when$atis adjusted at the end of the loop.This allows for some conditionals to be removed from the loop because they become invariants. The loop is always exited by the
whilecondition after the entire string has been processed.Trac ticket: https://core.trac.wordpress.org/ticket/65846
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.