Skip to content

HTML API: Simplify the class_list loop - #8076

Open
sirreal wants to merge 4 commits into
WordPress:trunkfrom
sirreal:html-api/class-list-whitespace-optimization
Open

HTML API: Simplify the class_list loop#8076
sirreal wants to merge 4 commits into
WordPress:trunkfrom
sirreal:html-api/class-list-whitespace-optimization

Conversation

@sirreal

@sirreal sirreal commented Jan 2, 2025

Copy link
Copy Markdown
Member

This is a simplification and optimization of the class_list loop based on some work in #7857.

The important change here is that the position ($at) advances past any whitespace characters before the while condition is checked. The loop never begins at whitespace characters allowing for a few checks to be eliminated and the overall loop logic to be simplificed. Whitespace is skipped before the loop is entered and when $at is adjusted at the end of the loop.

This allows for some conditionals to be removed from the loop because they become invariants. The loop is always exited by the while condition after the entire string has been processed.

Trac ticket: https://core.trac.wordpress.org/ticket/65846


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

github-actions Bot commented Jan 2, 2025

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

This comment was marked as low quality.

Defer whitespace scanning until class_list() resumes. This avoids scanning a long whitespace suffix when callers stop after a match.
@sirreal
sirreal marked this pull request as ready for review August 11, 2026 07:38
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jonsurrell.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants