[Fix] DeepSeek Flash cannot read attached images - #1618
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📜 Recent review details🧰 Additional context used📓 Path-based instructions (6)Treat model, provider, MCP, path, command, and tool data as untrusted.⚙️ CodeRabbit configuration file Files:
For persisted settings, verify the complete schema/storage/runtime/webview round trip, shared default semantics, and focused true plus false/unset tests.⚙️ CodeRabbit configuration file Files:
Require regression coverage at the lowest valid harness with behavior-focused assertions, including relevant negative, error, false/unset, and boundary cases.⚙️ CodeRabbit configuration file Files:
Check strict typing and exhaustive behavior across normal, boundary, error, cancellation, retry, and compatibility paths.⚙️ CodeRabbit configuration file Files:
Verify extension/webview contracts, cancellation and error propagation, VS Code lifecycle correctness, and behavior under retries and partial failure.⚙️ CodeRabbit configuration file Files:
Act as an adversarial second-opinion reviewer.⚙️ CodeRabbit configuration file Files:
🪛 GitHub Check: mutation-diffsrc/api/providers/deepseek.ts[warning] 35-35: Mutation test advisory [warning] 34-34: Mutation test advisory [warning] 33-33: Mutation test advisory [warning] 32-32: Mutation test advisory [warning] 31-31: Mutation test advisory 🔇 Additional comments (6)
📝 SummarySummary by CodeRabbit
WalkthroughThe DeepSeek provider now uses ChangesDeepSeek Flash model migration
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The DeepSeek Flash migration updates the canonical model and legacy aliases consistently, with coverage for image support, reasoning controls, pricing, defaults, and discovery. Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error, 1 warning)
✅ Passed checks (6 passed)
Full details: Description checkResolution Add the required template sections. Provide an approved issue reference such as Full details: Regression EvidenceExplanation The pull request removes Resolution Add a catalog test that asserts ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review statusThis PR was opened by an automated account. A human maintainer must verify the change intent, provenance, and validation before merging. Current step: Mark the PR ready. Required CI must pass before CodeRabbit starts. Review-state labels are managed by this workflow; do not edit them manually. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
@CodeRabbit review |
✅ Action performedReview finished.
|
|
Addressed the requested regression evidence and PR-template compliance in
|
Related GitHub Issue
N/A. No approved GitHub issue is linked to this PR.
Description
DeepSeek's September 10 V4.1 release made
deepseek-flashnatively multimodal and temporarily routes the retireddeepseek-v4-flashanddeepseek-v4-flash-vision-expIDs to the same model. Zoo Code previously treated the canonical ID as unknown and blocked images fordeepseek-v4-flash.This change adds
deepseek-flashas the default, enables image input for the supported Flash IDs, keepsdeepseek-v4-protext-only, aligns the retired aliases with current pricing and behavior, and adds regression coverage for model discovery, image transport, and disabled-reasoning temperature behavior.Test Procedure
pnpm --filter @roo-code/types exec vitest run src/__tests__/deepseek-v4-pro.test.ts.pnpm --dir src exec vitest run api/providers/__tests__/deepseek.spec.ts api/providers/fetchers/__tests__/deepseek.spec.ts.pnpm check-types.deepseek-flashor a supported legacy Flash alias, attach an image, and confirm the request is accepted. Confirmdeepseek-v4-prostill does not offer image attachment support.Pre-Submission Checklist
Visual Snapshots
N/A. No visual UI state changed.
Videos (interaction / animation only)
N/A. No interaction or animation changed.
Documentation Updates
Paired Zoo-Code-Docs PR: Zoo-Code-Org/Zoo-Code-Docs#60
Additional Notes
Authoritative DeepSeek references:
Get in Touch
Follow up by mentioning
@roomoteon this PR, through the linked Roomote session, or in the linked Discord thread.