[Improve] Make mutation warnings easier to review - #1619
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📜 Recent review details🧰 Additional context used📓 Path-based instructions (2)Check strict typing and exhaustive behavior across normal, boundary, error, cancellation, retry, and compatibility paths.⚙️ CodeRabbit configuration file Files:
Act as an adversarial second-opinion reviewer.⚙️ CodeRabbit configuration file Files:
🔇 Additional comments (2)
📝 SummarySummary by CodeRabbit
WalkthroughThe Stryker diff reporting now groups annotations by mutation location, removes redundant aggregate advisories, supports injected mutation report functions, and marks rows with blocking mutants as advisory findings. Tests cover the updated behavior. ChangesStryker reporting behavior
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to Mutation warnings remain advisory while detailed location annotations and manifest result rows retain the intended reporting behavior. 🚥 Pre-merge checks | ✅ 7 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (7 passed)
Full details: Description checkExplanation The description explains the change, motivation, impact, and related issues, but it omits the required issue-link format, Test Procedure section, Pre-Submission Checklist, documentation impact, and other template sections.
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review statusThis PR was opened by an automated account. A human maintainer must verify the change intent, provenance, and validation before merging. Current step: The required review sequence passed. Remaining merge requirements apply. Review-state labels are managed by this workflow; do not edit them manually. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
@CodeRabbit review |
✅ Action performedReview finished.
|
|
Addressed the Regression Evidence failure in Focused tests now execute successful Validation passed: focused mutation tests 39/39, formatting, lint, types, full tests, and |
|
@CodeRabbit review |
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
@CodeRabbit review |
|
2 participants
What changed
Mutation testing now emits at most one Files changed warning per source location. When several mutants share a line, the warning reports the grouped count and one representative example; each message includes its file and line so repeated mutant types remain distinguishable in logs.
Survivor and no-coverage package aggregates are no longer emitted as separate workflow warnings when the detailed location annotations already communicate those findings. The job summary and mutation report artifact continue to list every mutant.
Focused coverage executes successful manifest runs for both
Advisory findingsandPassedresults, and locks annotation input immutability, deterministic representative selection, and singleton formatting. The runtime path uses the same defaults as before; the added injection points are test-only seams.Why this change was made
The advisory mutation output introduced by #1610 produced repeated, indistinguishable warnings on #1614. Consolidating the annotation surface preserves useful review signals without flooding Files changed or hiding detailed evidence.
Impact
Mutation findings remain advisory. The existing executable-line cap and failures that prevent trustworthy scope calculation remain the only blocking behavior.
Related: #1610, #1614.