fix(grpc): allow omitted push config ids - #1163
Merged
Merged
Conversation
Signed-off-by: wj56 <823072490@qq.com>
Collaborator
|
Thank you @56wj |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(grpc): support omitted push notification config ids
Summary
Follow up on #1092:
GetTaskPushNotificationConfigParamspermits an omitted configuration ID, andDefaultRequestHandlerresolves null/empty IDs to the task ID. However,GrpcTransportstill rejects an omitted ID before sending the RPC, unlikeRestTransport.grpc-inprocessonly as a test-scoped dependency. No production dependencies or public API changes.Verification
Before the fix,
GrpcTransportTestran 5 tests with 3 errors (IllegalArgumentException: Parameter 'id' may not be null), all on omitted-ID paths.After the fix:
mvn -pl client/transport/grpc,client/transport/rest -am test557 tests across the two transports and their dependency modules passed, with 0 failures, errors, or skipped tests. This is the selected reactor, not the entire repository.
Refs #1012; follow-up to #1092. The original issue's null-ID premise predates #1092; this PR addresses the remaining client-side omission rather than choosing a new blank-ID policy.
Developed with AI coding assistance, with failing-before/passing-after regression evidence.