Conversation
- io.ably.lib.rest -> io.ably.pubsub.http. Merging into the existing io.ably.lib.http would have collided with Http/HttpCore/HttpAuth and the other 15 types already there, and io.ably.pubsub.* is where this major's packages live. The pubsub-adapter classes that sit in this package for package-private access move with it, so that access still resolves. - AblyRest -> AblyHttpClient, naming the thing it is rather than the protocol style. RestClient/RestChannel/RestPresence -> Http*, the adapters and wrappers likewise, RestAnnotations -> HttpAnnotations, TestRestClient -> TestHttpClient, and the io.ably.lib.test.rest suite -> io.ably.lib.test.http with Rest*Test -> Http*Test and RestSuite -> HttpSuite. - The gradle task testRestSuite -> testHttpSuite, with integration-test.yml and CONTRIBUTING updated to match, and the proguard Auth** keep rule repointed at the new package. Move the SDK to io.ably.pubsub and rename the client classes Deliberately left alone: - ClientOptions.restHost and idempotentRestPublishing. These are the cross-SDK option names fixed by the client library spec (RSC11, RSC9/TO3n), so renaming them would diverge this SDK from the spec and break user config for no gain here. - The word REST in prose and docs URLs. Ably's REST API is the product's own name and ably.com/docs/rest/... links have to keep resolving, so only identifiers moved; bare-word prose reads "HTTP" where it described the client rather than the API. - The check-rest-* CI job names, which are required status checks on the PR and would fail branch protection if renamed here. - Restore, restrictions, hamcrest and the restpresence_*/rest_presence* fixture keys, which merely contain the substring. CHANGELOG.md is untouched as a historical record. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Important Review skippedToo many files! This PR contains 485 files, which is 385 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (485)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.