Repository navigation
replace key worker with elixir-wallet #132
Description
Activity
The elixir wallet should be included as hex dependency and the Key Manager should be removed. Wherever the Key Manager is called functions from the wallet should be called now
@thepiwo Looking at the Keys module, it seems that I won't be able just to remove it and use the functionality from the elixir-wallet, because in this module there are some things that I cannot do simply with the elixir-wallet functions. Maybe I can alter the module to such extend that I use the functions from the elixir-wallet, but leave the other stuff.
Edit: Maybe if I move the sign_tx() function inside the SignedTx module it could work, and I could remove the whole Keys module
signing should work with the wallet as well, what other issues are there?
There is a signing functionality in the wallet, but the signing function in the core is different in the way that it actually creates the Tx itself:
def sign_tx(to_acc, value, nonce, fee, lock_time_block \\ 0) do {:ok, from_acc} = pubkey() {:ok, tx_data} = TxData.create(from_acc, to_acc, value, nonce, fee, lock_time_block) {:ok, signature} = sign(tx_data) signed_tx = %SignedTx{data: tx_data, signature: signature} {:ok, signed_tx} end
yeah you can put this function in the SignedTx and call the wallet code from there
Reacted by Georgi Spasov@thepiwo
@meivantodorov
Edited: Blockers: This pull request should be accepted before we continue our work. I have fixed the namings of the modules.- added 4 commits that reference this issue
on Jan 9, 2018 24 remaining items
- added 11 commits that reference this issue
on Feb 19, 2018 - added a commit that references this issue
on Mar 1, 2018
can be started when https://github.com/aeternity/elixir-wallet/issues/58 is finished