Add Mock Jutsu to Fixtures - #1336
Open
altansayan wants to merge 1 commit into
Open
altansayan wants to merge 1 commit into
altansayan wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="README_SOURCE.md">
<violation number="1" location="README_SOURCE.md:1157">
P3: The description lists BIC/SWIFT among "checksum-valid ... test data" examples, but ISO 9362 BIC/SWIFT codes carry no check digit — they are validated against the SWIFT registry, not a checksum algorithm (unlike the other listed items: IBAN MOD-97, Luhn card numbers, and check-digit ISIN/TCKN). Rephrase so BIC/SWIFT is not implied to be checksum-valid.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| - [Instancio](https://github.com/instancio/instancio) - Automates data setup in unit tests by generating fully-populated, reproducible objects. Includes JUnit 5 extension. | ||
| - [Randomized Testing](https://github.com/randomizedtesting/randomizedtesting) - JUnit test runner and plugins for running JUnit tests with pseudo-randomness. | ||
| - [JMock](https://github.com/xcancloud/JMock) - JMock is a high-performance data generation and simulation component library implemented in Java. | ||
| - [Mock Jutsu](https://github.com/altansayan/mock-jutsu-java) - Zero-dependency library generating checksum-valid financial and identity test data such as IBAN (MOD-97), Luhn-valid card numbers, national IDs, ISIN, and BIC/SWIFT, with a CLI, REST API, and JMeter plugin in addition to the SDK. Published on [Maven Central](https://central.sonatype.com/artifact/io.github.altansayan/mockjutsu). |
There was a problem hiding this comment.
P3: The description lists BIC/SWIFT among "checksum-valid ... test data" examples, but ISO 9362 BIC/SWIFT codes carry no check digit — they are validated against the SWIFT registry, not a checksum algorithm (unlike the other listed items: IBAN MOD-97, Luhn card numbers, and check-digit ISIN/TCKN). Rephrase so BIC/SWIFT is not implied to be checksum-valid.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At README_SOURCE.md, line 1157:
<comment>The description lists BIC/SWIFT among "checksum-valid ... test data" examples, but ISO 9362 BIC/SWIFT codes carry no check digit — they are validated against the SWIFT registry, not a checksum algorithm (unlike the other listed items: IBAN MOD-97, Luhn card numbers, and check-digit ISIN/TCKN). Rephrase so BIC/SWIFT is not implied to be checksum-valid.</comment>
<file context>
@@ -1154,6 +1154,7 @@ _Everything related to the creation and handling of random data._
- [Instancio](https://github.com/instancio/instancio) - Automates data setup in unit tests by generating fully-populated, reproducible objects. Includes JUnit 5 extension.
- [Randomized Testing](https://github.com/randomizedtesting/randomizedtesting) - JUnit test runner and plugins for running JUnit tests with pseudo-randomness.
- [JMock](https://github.com/xcancloud/JMock) - JMock is a high-performance data generation and simulation component library implemented in Java.
+- [Mock Jutsu](https://github.com/altansayan/mock-jutsu-java) - Zero-dependency library generating checksum-valid financial and identity test data such as IBAN (MOD-97), Luhn-valid card numbers, national IDs, ISIN, and BIC/SWIFT, with a CLI, REST API, and JMeter plugin in addition to the SDK. Published on [Maven Central](https://central.sonatype.com/artifact/io.github.altansayan/mockjutsu).
#### Frameworks
</file context>
Suggested change
| - [Mock Jutsu](https://github.com/altansayan/mock-jutsu-java) - Zero-dependency library generating checksum-valid financial and identity test data such as IBAN (MOD-97), Luhn-valid card numbers, national IDs, ISIN, and BIC/SWIFT, with a CLI, REST API, and JMeter plugin in addition to the SDK. Published on [Maven Central](https://central.sonatype.com/artifact/io.github.altansayan/mockjutsu). | |
| - [Mock Jutsu](https://github.com/altansayan/mock-jutsu-java) - Zero-dependency library generating checksum-valid financial and identity test data such as IBAN (MOD-97), Luhn-valid card numbers, national IDs, and ISIN, as well as BIC/SWIFT, with a CLI, REST API, and JMeter plugin in addition to the SDK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mock Jutsu generates checksum-valid test data for financial and identity fields — IBAN (ISO 13616 MOD-97), card numbers (Luhn), national IDs, ISIN, and BIC/SWIFT — where fixtures like Datafaker/jFairy generate format-plausible values, every Mock Jutsu value passes the real validation algorithm.
Summary by cubic
Adds Mock Jutsu to the Fixtures section of
README_SOURCE.md, distinguishing it from existing fixture libraries by generating checksum-valid financial and identity test data — IBAN (MOD-97), Luhn-valid card numbers, national IDs, ISIN, and BIC/SWIFT — so every value passes real validation algorithms.Written for commit c36afad. Summary will update on new commits.