Repository navigation
Require Python 3.11 and zarr 3 - #1
Merged
Merged
Conversation
No zarr 3 release supports Python 3.10, so the test dependencies of this branch could not be installed there. The minimum Python version is now 3.11, in the package metadata, the test matrix, and the Read the Docs build. The test workflow set up Python 3.11 for every job, whatever the matrix said, so the jobs named for Python 3.10 and 3.14 both ran on 3.11. It now uses the matrix version. Saving a probe with zarr 2 installed raises an ImportError that says zarr 3 is required, in place of an AttributeError. A new test saves a probe in a zarr format 2 group and reads it back, since that is the format existing files are in. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
alejoe91
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This goes on top of SpikeInterface#387.
No zarr 3 release supports Python 3.10, so with
zarr>=3,<4in the test group the test dependencies cannot be installed on 3.10, which probeinterface declares support for. This raises the minimum Python version to 3.11 in the package metadata, the test matrix, and the Read the Docs build.CI did not show the problem because
full_tests.ymlsets up Python 3.11 for every job, whatever the matrix says, so the jobs named for 3.10 and 3.14 both ran on 3.11. That is also the case on main. The workflow now uses the matrix version, which means the 3.14 jobs will run on 3.14 for the first time. Locally the tests pass on 3.11, 3.12, and 3.14 on macOS.Saving a probe with zarr 2 installed now raises an
ImportErrorthat says zarr 3 is required, in place of anAttributeErrorwith no message. A new test saves a probe in a zarr format 2 group and reads it back, since that is the format existing files are in. I also checked that a probe written by main with zarr 2.18 reads back equal with this branch and zarr 3.4.🤖 Generated with Claude Code