Preserve final newline in sqlformat output - #900
Open
RamiNoodle733 wants to merge 2 commits into
Open
RamiNoodle733 wants to merge 2 commits into
RamiNoodle733 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #637.
sqlparse.format()serializes each statement withSerializerUnicode, which strips trailing whitespace from split lines. For the CLI that means a SQL file ending in a newline can be emitted without its final newline.This keeps the library formatter behavior unchanged and fixes the CLI boundary instead: if the input ended in a newline and formatted output no longer does,
sqlformatrestores one before writing it. Inputs without a final newline remain unchanged.Regression coverage checks both newline/no-newline stdout behavior and the
--in-placepath.Validation: I inspected the focused branch diff against current
master. I could not run the project test suite in this automation environment because a runnable checkout is unavailable, so no local pytest result is claimed.