Avoid truncating files when sqlformat options are invalid - #901
Open
RamiNoodle733 wants to merge 1 commit into
Open
RamiNoodle733 wants to merge 1 commit into
RamiNoodle733 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sqlformat --in-placecurrently opens the input path for writing before formatter options are validated. Because opening withwtruncates immediately, an invalid formatting option such as--indent_width 0can destroy the input file even though formatting fails.This moves formatter-option validation ahead of output-stream creation, so invalid options return an error without touching the destination. Normal output selection and formatting behavior are otherwise unchanged.
A focused regression test verifies that an invalid in-place invocation returns an error and preserves the original file contents.
Validation: the change was reviewed against current
master. I could not run the repository test suite locally because this automation environment cannot resolve GitHub for a checkout, so no local pytest result is claimed.AI assistance was used to identify the destructive ordering bug, inspect repository guidance, and prepare the focused fix and regression coverage.