Conversation
MbappeWU
marked this pull request as ready for review
October 3, 2026 20:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #722.
An operator immediately followed by a comment can consume the start of that comment. Valid SQL such as
SELECT 'a' ||--comment;\n'b'; SELECT 2;then splits into three statements instead of two, andstrip_comments=Trueleaves the comment in place. The same boundary problem affects#and/* ... */, including semicolons inside block comments.Stop operator runs before existing comment openers, and prevent the JSON
#-pattern from taking the first dash of#--. Preserve the standalone unterminated/*fallback and established hint, quoted-string and normal operator behavior. Related historical PR #878 was closed unmerged by its author; this patch independently covers the block-comment and JSON-prefix cases as well.Validation:
a2cd648d0e0328cc795528c8d5897ebbf28cd086differs from PR head only in those two event additions. The PR workflows are unchanged.Developed with Codex, with separate local code and input-behavior reviews. This PR changes only the lexer rules and their regression tests.