Repository navigation
Migrate Baseline Profiles and Startup Profiles snippets - #1097
pengzhi-cb wants to merge 11 commits into
Conversation
|
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
d5d4716 to
78e4622
Compare
|
Is it possible to remove the new snippets from the misc folder? (We don't want to add any new snippets to that module). Can they go into the performance module, or do they need to go in the performance-samples repo? |
Oops, I did move them but the commit was lost when I move things into |
502561b to
edac329
Compare
kkuan2011
left a comment
There was a problem hiding this comment.
After the move to the performance module, I think we're missingLaunchTime.kt file with its snippet?
I also updated CL description to reflect this |
kkuan2011
left a comment
There was a problem hiding this comment.
Looks great, thank you Peng!
|
Can you rebase? |
52a29d7 to
79ddd23
Compare
…ch Time) snippets
…nitialization crashes - Upgrade androidx-benchmark to 1.4.1 and androidx-uiautomator to 2.4.0. - Relocate benchmarking tests from production source (src/main) to the test source set (src/androidTest). - Fix startup crash by making `SplitInitializer` a static inner class in `ActivityEmbeddingJavaSnippets.java`. - Update `AndroidManifest.xml` to correctly reference nested initializer classes using the `$` separator. - Adopt the new UI Automator 2.4.0 in `BaselineProfilesOverview.kt`.
- Consolidate and clean up testing dependencies in `misc/build.gradle.kts`. - Reorganize UI Automator library declaration in `libs.versions.toml` for better consistency.
- Remove static modifier from ActivityEmbeddingJavaSnippets.SplitInitializer - Fix AndroidManifest App Startup meta-data inner class reference paths - Update androidx-metrics to 1.0.0
79ddd23 to
33457fd
Compare
|
LGTM |
Code snippets are for:
Total: 3 code snippets (3 Kotlin and 0 XML) across 3 pages.
List of modifications
@RunWith(AndroidJUnit4ClassRunner::class)with@RunWith(AndroidJUnit4::class), fixed parameter namewarmupIteration = 3towarmupIterations = 3inCompilationMode.Partial(...), and normalized spacing before the closing brace on line 76 (android_performance_baselineprofiles_measure_compilation_modesinMeasureBaselineProfile.kt).}for theuiAutomatorblock so the snippet compiles and formattedstartIntent(...)across multiple lines (android_performance_startupprofiles_generatorinDexLayoutOptimizations.kt).Snippets not migrated