Skip to content

perf(@angular/build): read rendered module length once per module in chunk optimizer #34045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clydin merged 3 commits into from
Sep 8, 2026
+5 −1
Merged

perf(@angular/build): read rendered module length once per module in chunk optimizer #34045

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d7138e
perf(@angular/build): read rendered module length once per module in …
roman-garcia Sep 8, 2026
657a323
Remove performance comments in chunk-optimizer.ts
roman-garcia Sep 8, 2026
308c23c
Update packages/angular/build/src/builders/application/chunk-optimize…
roman-garcia Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/angular/build/src/builders/application/chunk-optimizer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,11 +113,15 @@ function bundleOutputToEsbuildMetafile(
continue;
}

// Read once per module: in Rolldown, `renderedLength` is an uncached getter that
// copies the entire module code across the NAPI bridge on each access.
const { renderedLength } = renderedModule;

for (const [originalInputPath, originalInputInfo] of Object.entries(
originalOutputEntry.inputs,
)) {
const proportion = originalInputInfo.bytesInOutput / totalOriginalBytesInModule;
const newBytesInOutput = Math.floor(renderedModule.renderedLength * proportion);
const newBytesInOutput = Math.floor(renderedLength * proportion);

const existing = newOutputInputs[originalInputPath];
if (existing) {
Expand Down
Loading