fix(@angular/build): scope cache directory by project and builder name - #34240
Merged
alan-agius4 merged 2 commits intoOct 2, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the validation check that prevents the library builder's output path from being the project root, containing the project root, or being located within the project root. The review feedback highlights that while allowing the output path to be within the project root is desirable, we must still prevent it from being exactly the project root or containing the project root to avoid accidental deletion of source files. Suggestions are provided to restore a modified validation check, retain the 'isSubDirectory' import, and reuse the resolved output path variable.
alan-agius4
changed the title
alan-agius4
force-pushed
the
fix/library-output-path-bazel
branch
from
October 2, 2026 08:00
2c197db to
4bdbfa2
Compare
alan-agius4
added
action: review
alan-agius4
force-pushed
the
fix/library-output-path-bazel
branch
from
October 2, 2026 08:18
4bdbfa2 to
dd9bf8a
Compare
alan-agius4
changed the title
alan-agius4
changed the title
alan-agius4
force-pushed
the
fix/library-output-path-bazel
branch
2 times, most recently
from
October 2, 2026 08:36
14dd9e5 to
ead7184
Compare
Accept optional `projectName` and `builderName` parameters in `normalizeCacheOptions` to consistently scope `path` and `localPath` per project and builder across the application, dev-server, library, ng-packagr, and unit-test builders. Without scoping the cache path by `builderName`, builders that invoke the application build pipeline (such as `unit-test` during `ng test` and `application` during `ng build`) share the same project cache directory and overwrite shared cache artifacts such as `.tsbuildinfo` files, preventing incremental caching from working properly.
alan-agius4
force-pushed
the
fix/library-output-path-bazel
branch
from
October 2, 2026 09:38
ead7184 to
431414e
Compare
clydin
reviewed
Oct 2, 2026
clydin
left a comment
clydin
left a comment
Member
There was a problem hiding this comment.
Looks like ng-packagr and unit-test already have some logic to add the builder name to the cache path. To avoid duplicate path segments, we should also remove/consolidate that logic.
clydin
approved these changes
Oct 2, 2026
alan-agius4
added
action: merge
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept optional
projectNameandbuilderNameparameters innormalizeCacheOptionsto consistently scopepathandlocalPathper project and builder across theapplication,dev-server,library,ng-packagr, andunit-testbuilders.Without scoping the cache path by
builderName, builders such asng test(unit-test) andng build(application) share the same project cache directory and overwrite shared cache files such as.tsbuildinfo, causing incremental caching not to work properly.