-
Notifications
You must be signed in to change notification settings - Fork 11.8k
perf(@angular/build): immediately purge freed rolldown arena memory #34245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
clydin
wants to merge
1
commit into
angular:main
Choose a base branch
from
clydin:perf/rolldown-arena-purge
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+113
−10
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| /** | ||
| * @license | ||
| * Copyright Google LLC All Rights Reserved. | ||
| * | ||
| * Use of this source code is governed by an MIT-style license that can be | ||
| * found in the LICENSE file at https://angular.dev/license | ||
| */ | ||
|
|
||
| const MIMALLOC_PURGE_DELAY = 'MIMALLOC_PURGE_DELAY'; | ||
|
|
||
| let rolldownPromise: Promise<typeof import('rolldown')> | undefined; | ||
|
|
||
| /** | ||
| * Dynamically loads the `rolldown` module while configuring its embedded | ||
| * mimalloc v3 allocator to immediately purge freed arena memory. | ||
| * | ||
| * Rolldown's native binding statically links mimalloc v3, which defaults to a | ||
| * 4-second arena purge delay (`MIMALLOC_PURGE_DELAY=1000` * `MIMALLOC_ARENA_PURGE_MULT=4`) | ||
| * and only triggers purges cooperatively during subsequent allocations. In single-run | ||
| * CLI builds where Rolldown is not invoked again after bundling completes, non-zero | ||
| * purge delays prevent freed arena pages from being decommitted back to the OS, | ||
| * leading to high peak RSS during post-bundle stages. | ||
| * | ||
| * Because mimalloc reads and caches environment options synchronously when the native | ||
| * `.node` addon is first loaded (`mi_process_init` -> `_mi_options_init`), temporarily | ||
| * setting `MIMALLOC_PURGE_DELAY=0` during the initial `import('rolldown')` call | ||
| * configures Rolldown's allocator without leaving the environment variable set for | ||
| * subsequent code or child processes. | ||
| * | ||
| * @returns A promise that resolves to the `rolldown` module namespace. | ||
| */ | ||
| export function loadRolldown(): Promise<typeof import('rolldown')> { | ||
| if (!rolldownPromise) { | ||
| const hasCustomPurgeDelay = Object.hasOwn(process.env, MIMALLOC_PURGE_DELAY); | ||
| if (!hasCustomPurgeDelay) { | ||
| process.env[MIMALLOC_PURGE_DELAY] = '0'; | ||
| } | ||
|
|
||
| rolldownPromise = import('rolldown').finally(() => { | ||
| if (!hasCustomPurgeDelay) { | ||
| delete process.env[MIMALLOC_PURGE_DELAY]; | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| return rolldownPromise; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| /** | ||
| * @license | ||
| * Copyright Google LLC All Rights Reserved. | ||
| * | ||
| * Use of this source code is governed by an MIT-style license that can be | ||
| * found in the LICENSE file at https://angular.dev/license | ||
| */ | ||
|
|
||
| const MIMALLOC_PURGE_DELAY = 'MIMALLOC_PURGE_DELAY'; | ||
|
|
||
| describe('loadRolldown', () => { | ||
| const originalEnvValue = process.env[MIMALLOC_PURGE_DELAY]; | ||
|
|
||
| function getFreshLoadRolldown(): typeof import('./load-rolldown') { | ||
| delete require.cache[require.resolve('./load-rolldown')]; | ||
|
|
||
| return require('./load-rolldown'); | ||
| } | ||
|
|
||
| afterEach(() => { | ||
| if (originalEnvValue !== undefined) { | ||
| process.env[MIMALLOC_PURGE_DELAY] = originalEnvValue; | ||
| } else { | ||
| delete process.env[MIMALLOC_PURGE_DELAY]; | ||
| } | ||
| delete require.cache[require.resolve('./load-rolldown')]; | ||
| }); | ||
|
|
||
| it('loads rolldown and cleans up temporary MIMALLOC_PURGE_DELAY when unset', async () => { | ||
| delete process.env[MIMALLOC_PURGE_DELAY]; | ||
| const { loadRolldown } = getFreshLoadRolldown(); | ||
|
|
||
| const promise1 = loadRolldown(); | ||
| expect(process.env[MIMALLOC_PURGE_DELAY]).toBe('0'); | ||
|
|
||
| const promise2 = loadRolldown(); | ||
| expect(promise1).toBe(promise2); | ||
|
|
||
| const rolldownModule = await promise1; | ||
| expect(typeof rolldownModule.rolldown).toBe('function'); | ||
| expect(Object.hasOwn(process.env, MIMALLOC_PURGE_DELAY)).toBeFalse(); | ||
| }); | ||
|
|
||
| it('preserves user-configured MIMALLOC_PURGE_DELAY when already set', async () => { | ||
| process.env[MIMALLOC_PURGE_DELAY] = '1000'; | ||
| const { loadRolldown } = getFreshLoadRolldown(); | ||
|
|
||
| const promise = loadRolldown(); | ||
| expect(process.env[MIMALLOC_PURGE_DELAY]).toBe('1000'); | ||
|
|
||
| const rolldownModule = await promise; | ||
| expect(typeof rolldownModule.rolldown).toBe('function'); | ||
| expect(process.env[MIMALLOC_PURGE_DELAY]).toBe('1000'); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.