ci: correct fork check in pull_request_target workflow - #33653
Merged
crisbeto merged 1 commit intoSep 9, 2026
Conversation
The condition github.event.repository.fork == false is ineffective in a pull_request_target context, since github.event.repository always refers to the base repository, never the fork. This meant the check always evaluated to true, allowing the job to run even for fork-originated PRs. Use github.event.pull_request.head.repo.fork instead, which correctly reflects the PR's actual source repository. Fixes angular#33632
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
angular-robot
Bot
added
the
area: build & ci
Contributor
Author
|
@googlebot I signed it! |
Contributor
Author
|
Hi @crisbeto — following up on this PR, it's been about a month since I opened it. The approach was confirmed by @mabrukhany-beep on the linked issue (#33632). Could you take a look, and approve the pending workflow runs / pullapprove review when you get a chance? Happy to make any changes if needed. |
crisbeto
approved these changes
Sep 9, 2026
crisbeto
added
action: merge
Member
crisbeto
pushed a commit
that referenced
this pull request
Sep 9, 2026
The condition github.event.repository.fork == false is ineffective in a pull_request_target context, since github.event.repository always refers to the base repository, never the fork. This meant the check always evaluated to true, allowing the job to run even for fork-originated PRs. Use github.event.pull_request.head.repo.fork instead, which correctly reflects the PR's actual source repository. Fixes #33632 (cherry picked from commit 1c79709)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33632
The condition
github.event.repository.fork == falseis ineffectivein a
pull_request_targetcontext, sincegithub.event.repositoryalways refers to the base repository, never the fork. This meant the
check always evaluated to true, allowing the job to run even for
fork-originated PRs.
Use
github.event.pull_request.head.repo.forkinstead, whichcorrectly reflects the PR's actual source repository.
Confirmed this approach with @mabrukhany-beep on the linked issue (#33632) before
implementing.