Skip to content

Add MillirevolutionPerMinute (mrpm) - #1669

Closed
Bondarenko1990 wants to merge 5 commits into
angularsen:masterfrom
Bondarenko1990:feature/added-millirevolutionperminute
Closed

Bondarenko1990 wants to merge 5 commits into
angularsen:masterfrom
Bondarenko1990:feature/added-millirevolutionperminute

Conversation

@Bondarenko1990

@Bondarenko1990 Bondarenko1990 commented May 28, 2026 •

Copy link
Copy Markdown

Summary

Adds millirevolution-based rotational units:

  • MillirevolutionPerMinute (mrpm, mr/min) for RotationalSpeed
  • MillirevolutionPerMinutePerSecond (mrpm/s) for RotationalAcceleration

Maintainer Updates

  • Regenerated code so the new units are present in Common/UnitEnumValues.g.json, generated unit enums, quantity code, resources, number extensions, and generated test bases.
  • Merged current master and resolved the stale nanoFramework generated-file conflicts by keeping the upstream removals.

Validation

  • Ran generate-code.bat.
  • Ran dotnet test UnitsNet.Tests --framework net9.0 --filter "FullyQualifiedName~RotationalSpeedTests|FullyQualifiedName~RotationalAccelerationTests" --no-restore --verbosity minimal.
  • Result: 571 focused tests passed after the merge.

@Bondarenko1990 Bondarenko1990 changed the title Added MillirevolutionPerMinute (mrpm) Add MillirevolutionPerMinute (mrpm) May 28, 2026

@angularsen angularsen left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any sources that back these up as commonly used?
They seem not common.

https://share.google/aimode/2OhMMWt81lKo9vt0m

@angularsen angularsen added the pending-response Waiting for response from author of PR/issue. label Jul 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions

Copy link
Copy Markdown
Contributor

This PR was automatically closed due to inactivity.

@github-actions github-actions Bot closed this Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-pr-activity pending-response Waiting for response from author of PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants