chore: remove @openpgp/web-stream-tools dependency - #476
Open
kentkwu wants to merge 1 commit into
Open
Conversation
Replace external dependency with local concatStream implementation. The package changed to ESM-only between v0.0.13 and v0.3.1, breaking Jest's module resolution even with Jest 30. Since only 3 tests use this simple utility, implementing it locally (~15 lines) is more maintainable than dealing with ESM compatibility issues. - Remove @openpgp/web-stream-tools from package.json - Add concatStream() helper in streams-dom-tests.ts - Remove package from jest.config.js transformIgnorePatterns - All 696 tests pass
kentkwu
force-pushed
the
fix/remove-web-stream-tools-dependency
branch
from
September 10, 2026 18:24
208edf4 to
6c1d8f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
@openpgp/web-stream-toolsdependency and replaces it with a localconcatStream()implementation.Verified all 696 tests in
test/unit/ipc/reader/streams-dom-tests.tspass with the local implementation.Test Plan
npm run buildTEST_DOM_STREAMS=true npx jest test/unit/ipc/reader/streams-dom-tests.ts(all 696 tests pass)Related
Closes dependabot PR #434 which attempted to upgrade this package but failed CI due to the ESM incompatibility.