GH-29839: [C++][Python][R] Rename binary set lookup functions - #51306
Open
faze-geek wants to merge 1 commit into
Open
GH-29839: [C++][Python][R] Rename binary set lookup functions#51306faze-geek wants to merge 1 commit into
faze-geek wants to merge 1 commit into
Conversation
faze-geek
requested review from
AlenkaF,
jonkeane,
pitrou,
raulcd,
rok and
thisisnic
as code owners
September 11, 2026 13:21
|
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes, compatibility aliases, tests, benchmarks, and documentation are covered with no unresolved issues.
Pull request overview
Renames binary set-lookup functions to canonical names while preserving compatibility aliases.
Changes:
- Registers
is_in_binaryandindex_in_binary. - Updates R callers, benchmarks, tests, and documentation.
- Retains legacy aliases and verifies alias handling.
File summaries
| File | Description |
|---|---|
r/R/dplyr-funcs-conditional.R |
Updates caller documentation. |
r/R/compute.R |
Uses canonical function names. |
python/pyarrow/tests/test_compute.py |
Tests canonical and legacy names. |
docs/source/python/api/compute.rst |
Documents canonical Python APIs. |
docs/source/cpp/compute.rst |
Documents canonical C++ functions. |
cpp/src/arrow/compute/kernels/scalar_set_lookup.cc |
Registers canonical functions and aliases. |
cpp/src/arrow/compute/kernels/scalar_set_lookup_test.cc |
Tests canonical and legacy names. |
cpp/src/arrow/compute/kernels/scalar_set_lookup_benchmark.cc |
Uses canonical benchmark names. |
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Author
|
@pitrou Would you mind approving workflows ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The public compute function names
is_in_meta_binaryandindex_in_meta_binaryexpose the internalMetaFunctionimplementationdetail.
What changes are included in this PR?
is_in_binaryandindex_in_binaryas the canonical names.is_in_meta_binaryandindex_in_meta_binaryas compatibilityaliases.
through aliases.
Are these changes tested?
Yes.
Are there any user-facing changes?
Closes #29839