Skip to content

GH-29839: [C++][Python][R] Rename binary set lookup functions - #51306

Open
faze-geek wants to merge 1 commit into
apache:mainfrom
faze-geek:gh-29839-rename-set-lookup-binary
Open

GH-29839: [C++][Python][R] Rename binary set lookup functions#51306
faze-geek wants to merge 1 commit into
apache:mainfrom
faze-geek:gh-29839-rename-set-lookup-binary

Conversation

@faze-geek

@faze-geek faze-geek commented Sep 11, 2026

Copy link
Copy Markdown

Rationale for this change

The public compute function names is_in_meta_binary and
index_in_meta_binary expose the internal MetaFunction implementation
detail.

What changes are included in this PR?

  • Register is_in_binary and index_in_binary as the canonical names.
  • Retain is_in_meta_binary and index_in_meta_binary as compatibility
    aliases.
  • Update Arrow-owned R callers and C++ benchmarks to use the canonical names.
  • Add C++ and Python coverage for both canonical and compatibility names.
  • Add the canonical names to the C++ and Python compute documentation.
  • Update the PyArrow registry-name test to account for canonical names returned
    through aliases.

Are these changes tested?

Yes.

Are there any user-facing changes?

Closes #29839

Copilot AI lite review requested due to automatic review settings September 11, 2026 13:21
@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #29839 has been automatically assigned in GitHub to PR creator.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes, compatibility aliases, tests, benchmarks, and documentation are covered with no unresolved issues.

Pull request overview

Renames binary set-lookup functions to canonical names while preserving compatibility aliases.

Changes:

  • Registers is_in_binary and index_in_binary.
  • Updates R callers, benchmarks, tests, and documentation.
  • Retains legacy aliases and verifies alias handling.
File summaries
File Description
r/R/dplyr-funcs-conditional.R Updates caller documentation.
r/R/compute.R Uses canonical function names.
python/pyarrow/tests/test_compute.py Tests canonical and legacy names.
docs/source/python/api/compute.rst Documents canonical Python APIs.
docs/source/cpp/compute.rst Documents canonical C++ functions.
cpp/src/arrow/compute/kernels/scalar_set_lookup.cc Registers canonical functions and aliases.
cpp/src/arrow/compute/kernels/scalar_set_lookup_test.cc Tests canonical and legacy names.
cpp/src/arrow/compute/kernels/scalar_set_lookup_benchmark.cc Uses canonical benchmark names.
Review details
  • Files reviewed: 8/8 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@faze-geek

Copy link
Copy Markdown
Author

@pitrou Would you mind approving workflows ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C++] Document and rename is_in_meta_binary

2 participants