[Iceberg CDC sink] Commit files stage - #40134
Open
ahmedabu98 wants to merge 3 commits into
Open
ahmedabu98 wants to merge 3 commits into
ahmedabu98 wants to merge 3 commits into
Conversation
ahmedabu98
marked this pull request as ready for review
September 17, 2026 10:05
Contributor
|
Assigning reviewers: R: @Abacn for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
3 tasks
chamikaramj
approved these changes
Sep 18, 2026
| * as its own single-snapshot commit. A configured {@code tokenHeartbeatMillis} adds an idle | ||
| * token-refresh timer ({@link #onHeartbeat}). | ||
| */ | ||
| static class OrderedCommitFn extends DoFn<KV<String, WindowedCommit>, KV<String, SnapshotInfo>> { |
Contributor
There was a problem hiding this comment.
This file is extremely long. Can we move some of the inner classes and interfaces into separate files ? Also add dedicated test classes when appropriate.
| // The "commit" timer is always armed at the earliest pending window's end. | ||
| long earliestPendingWindowEnd = c.timestamp().getMillis(); | ||
| // Current input watermark tells us that all past pending windows are safe to commit. | ||
| long inputWatermark = timer.getCurrentRelativeTime().getMillis(); |
Contributor
There was a problem hiding this comment.
This might be runner dependent. Let's adjust or document (if the correctness is preserved).
| .apply("KeyByDestination", WithKeys.of(ShardDeltaFiles::getTableIdentifierString)) | ||
| .setCoder(KvCoder.of(StringUtf8Coder.of(), ShardDeltaFiles.coder())) | ||
| // One element per (dest, window): every shard's output for the pair. | ||
| .apply("GatherShardsPerWindow", GroupByKey.create()) |
Contributor
There was a problem hiding this comment.
Do we have to handle late data via after this GBK similar to CommitWindows ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the commit stage. Driven by a stateful DoFn that commits each window's data and equality-delete files as one snapshot.
Includes the following in each snapshot summary for idempotency:
On retry or restart, recovers the token from the table's ancestry to skip already-committed windows, with a heartbeat that keeps the token fresh while the stream is idle.
Part of #39979
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.