Repository navigation
Conversation
snuyanzin
commented
Aug 29, 2026
| * <a href="https://issues.apache.org/jira/browse/CALCITE-7753">[CALCITE-7753] | ||
| * CorrelateProjectExtractor corrupts plans with nested Correlates that reuse | ||
| * the same correlation id</a>. */ | ||
| @Test void testNestedCorrelatesSharingCorrelationId() { |
Contributor
Author
There was a problem hiding this comment.
As mentioned in jira: it is not reproducible with pure SQL in Calcite
Contributor
Author
There was a problem hiding this comment.
Because the bug requires two nested Correlates that share the same correlation id, and pure SQL (in Calcite) never produces that shape: Calcite's SqlToRelConverter gives every correlated subquery scope its own id.
Contributor
|
I left a comment related to this in Jira questioning whether this fix belongs in Calcite. |
mihaibudiu
approved these changes
Aug 31, 2026
zabetak
reviewed
Sep 1, 2026
snuyanzin
force-pushed
the
calcite7753
branch
from
September 15, 2026 10:35
1f47f48 to
fb9a626
Compare
zabetak
approved these changes
Oct 6, 2026
Contributor
|
I guess is commit squash time! |
mihaibudiu
added
the
LGTM-will-merge-soon
… Correlates that reuse the same correlation id
Contributor
Author
|
yep, makes sense |
Contributor
Author
|
Merged as 25d62c5 |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
CALCITE-7753
Changes Proposed
The change to fix
CorrelateProjectExtractorfor downstream projects