Skip to content

Deal with Storage Manager tech debt - #13598

Draft
DaanHoogland wants to merge 2 commits into
mainfrom
ghi12316-storageManagerTechDebt
Draft

Deal with Storage Manager tech debt#13598
DaanHoogland wants to merge 2 commits into
mainfrom
ghi12316-storageManagerTechDebt

Merge branch 'main' into ghi12316-storageManagerTechDebt

50ddab2
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Sep 7, 2026 in 5m 58s

Quality Gate failed

Failed conditions
8.3% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 433 in server/src/main/java/com/cloud/storage/StorageManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Invoke method(s) only conditionally. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaB7GgVuPiSI7SAy2f7b&open=AaB7GgVuPiSI7SAy2f7b&pullRequest=13598

Check warning on line 100 in plugins/storage/image/s3/src/main/java/org/apache/cloudstack/storage/datastore/driver/S3ImageStoreDriverImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

No need to call "toString()" method as formatting and string conversion is done by the Formatter. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaB7GgOFPiSI7SAy2f7X&open=AaB7GgOFPiSI7SAy2f7X&pullRequest=13598

Check warning on line 3503 in server/src/main/java/com/cloud/storage/StorageManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Invoke method(s) only conditionally. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaB7GgVuPiSI7SAy2f7c&open=AaB7GgVuPiSI7SAy2f7c&pullRequest=13598

Check failure on line 3690 in server/src/main/java/com/cloud/storage/StorageManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 22 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaB7GgVuPiSI7SAy2f7f&open=AaB7GgVuPiSI7SAy2f7f&pullRequest=13598

Check warning on line 3510 in server/src/main/java/com/cloud/storage/StorageManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Invoke method(s) only conditionally. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaB7GgVuPiSI7SAy2f7d&open=AaB7GgVuPiSI7SAy2f7d&pullRequest=13598

Check warning on line 2063 in server/src/main/java/com/cloud/storage/StorageManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this if statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaB7GgVuPiSI7SAy2f7a&open=AaB7GgVuPiSI7SAy2f7a&pullRequest=13598

Check warning on line 2023 in server/src/main/java/com/cloud/storage/StorageManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this if statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaB7GgVuPiSI7SAy2f7Z&open=AaB7GgVuPiSI7SAy2f7Z&pullRequest=13598

Check failure on line 825 in server/src/main/java/com/cloud/storage/StorageManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 36 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaB7GgVuPiSI7SAy2f7e&open=AaB7GgVuPiSI7SAy2f7e&pullRequest=13598

Check warning on line 100 in plugins/storage/image/s3/src/main/java/org/apache/cloudstack/storage/datastore/driver/S3ImageStoreDriverImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Invoke method(s) only conditionally. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaB7GgOFPiSI7SAy2f7W&open=AaB7GgOFPiSI7SAy2f7W&pullRequest=13598

Check warning on line 712 in server/src/main/java/com/cloud/storage/StorageManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Merge this if statement with the enclosing one. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaB7GgVuPiSI7SAy2f7Y&open=AaB7GgVuPiSI7SAy2f7Y&pullRequest=13598
View more details on SonarQubeCloud