Skip to content

backport: Incremental NAS backup support for KVM (#13074) - #13877

Merged
harikrishna-patnala merged 11 commits into
4.22from
nas-backport
Sep 17, 2026
Merged

harikrishna-patnala merged 11 commits into
4.22from
nas-backport

Address review comments: null/empty checks and restore answer guard

41b616b
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Sep 17, 2026 in 7m 53s

Quality Gate failed

Annotations

Check failure on line 34 in api/src/main/java/org/apache/cloudstack/backup/Backup.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaALhNLOoex1GfKC-SZT&open=AaALhNLOoex1GfKC-SZT&pullRequest=13877

Check warning on line 633 in plugins/backup/nas/src/test/java/org/apache/cloudstack/backup/NASBackupProviderTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaALhNTmoex1GfKC-SZc&open=AaALhNTmoex1GfKC-SZc&pullRequest=13877

Check failure on line 34 in api/src/main/java/org/apache/cloudstack/backup/Backup.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaALhNLOoex1GfKC-SZU&open=AaALhNLOoex1GfKC-SZU&pullRequest=13877

Check failure on line 34 in api/src/main/java/org/apache/cloudstack/backup/Backup.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaALhNLOoex1GfKC-SZW&open=AaALhNLOoex1GfKC-SZW&pullRequest=13877

Check failure on line 559 in plugins/backup/nas/src/main/java/org/apache/cloudstack/backup/NASBackupProvider.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 27 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaALhNVhoex1GfKC-SZd&open=AaALhNVhoex1GfKC-SZd&pullRequest=13877

Check warning on line 613 in plugins/backup/nas/src/test/java/org/apache/cloudstack/backup/NASBackupProviderTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaALhNTmoex1GfKC-SZa&open=AaALhNTmoex1GfKC-SZa&pullRequest=13877

Check warning on line 604 in plugins/backup/nas/src/test/java/org/apache/cloudstack/backup/NASBackupProviderTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaALhNTmoex1GfKC-SZZ&open=AaALhNTmoex1GfKC-SZZ&pullRequest=13877

Check failure on line 34 in api/src/main/java/org/apache/cloudstack/backup/Backup.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaALhNLOoex1GfKC-SZQ&open=AaALhNLOoex1GfKC-SZQ&pullRequest=13877

Check warning on line 1167 in plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/guru/VMwareGuru.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Invoke method(s) only conditionally.

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaALhNQioex1GfKC-SZY&open=AaALhNQioex1GfKC-SZY&pullRequest=13877

Check failure on line 34 in api/src/main/java/org/apache/cloudstack/backup/Backup.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaALhNLOoex1GfKC-SZR&open=AaALhNLOoex1GfKC-SZR&pullRequest=13877

Check warning on line 614 in plugins/backup/nas/src/test/java/org/apache/cloudstack/backup/NASBackupProviderTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when".

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaALhNTmoex1GfKC-SZb&open=AaALhNTmoex1GfKC-SZb&pullRequest=13877

Check failure on line 34 in api/src/main/java/org/apache/cloudstack/backup/Backup.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaALhNLOoex1GfKC-SZV&open=AaALhNLOoex1GfKC-SZV&pullRequest=13877

Check failure on line 34 in api/src/main/java/org/apache/cloudstack/backup/Backup.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaALhNLOoex1GfKC-SZX&open=AaALhNLOoex1GfKC-SZX&pullRequest=13877

Check failure on line 34 in api/src/main/java/org/apache/cloudstack/backup/Backup.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaALhNLOoex1GfKC-SZS&open=AaALhNLOoex1GfKC-SZS&pullRequest=13877

Check failure on line 34 in api/src/main/java/org/apache/cloudstack/backup/Backup.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaALhNLOoex1GfKC-SZP&open=AaALhNLOoex1GfKC-SZP&pullRequest=13877