config cleanup

[DaanHoogland]

Description

This PR tries to get rid of the Config enum or the old mechanism to define configuration items, which is long overdue. The change should be transparent, but is huge so good regression testing is required. And merg early in the release cycle is recommended.
Commits are being done in batches for review convenience. They could have been done in separate PRs but in the end the changes are rather trivial.

Fixes: #10752

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.70%. Comparing base (af9764b) to head (576d4e0).

❗ There is a different number of reports uploaded between BASE (af9764b) and HEAD (576d4e0). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (af9764b)	HEAD (576d4e0)
unittests	1	0

Additional details and impacted files

@@              Coverage Diff              @@
##               main   #13884       +/-   ##
=============================================
- Coverage     20.45%    3.70%   -16.75%     
=============================================
  Files          6487      493     -5994     
  Lines        589303    42558   -546745     
  Branches      72245     8063    -64182     
=============================================
- Hits         120525     1578   -118947     
+ Misses       455643    40751   -414892     
+ Partials      13135      229    -12906     

Flag	Coverage Δ
uitests	3.70% <ø> (ø)
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

🔴 Test Coverage Grade: D — Marginal

Metric	Value
Line coverage	24.69%
Branch coverage	18.92%

Grade Scale

Grade	Line Coverage	Meaning
🟢 A	≥ 80%	Excellent - this code sleeps well at night 😴
🟡 B	60-79%	Good - almost there, don't stop now 😉
🟠 C	40-59%	Acceptable - your code is wearing a seatbelt, but no airbags 😬
🔴 D	20-39%	Marginal - boldly shipping where no test has gone before 🖖
⛔ F	< 20%	Failing - tests? what tests? 🔥

Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 19628

[Copilot]

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

5 open issues

• The default value hard-codes credentials (\"admin1:AdMiN123\") for HAProxy stats auth. This is an…
• Long.parseLong(_configDao.getValue(...)) can throw NPE/NumberFormatException when the config key…
• This introduces yet another local ConfigKey definition for detail.batch.query.size (similar… · New
• The description text should use the plural form for units. Consider changing 'In second' to 'In… · New
• The description for publish.resource.state.events is inaccurate: it refers to 'alert events', but… · New

1 resolved since last review

• This method partially migrated to typed config (SecStorageEncryptCopy.value()) but still reads…

_{Review effort: Lite}

[Copilot]

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

7 open issues

• The default value hard-codes credentials (\"admin1:AdMiN123\") for HAProxy stats auth. This is an…
• Long.parseLong(_configDao.getValue(...)) can throw NPE/NumberFormatException when the config key…
• The HAProxy stats port is modeled as a String but is consumed numerically elsewhere (e.g., parsed… · New
• This PR introduces multiple local duplicated ConfigKey declarations for the same underlying… · New
• This introduces yet another local ConfigKey definition for detail.batch.query.size (similar…
• The description for publish.resource.state.events is inaccurate: it refers to 'alert events', but…
• The description text should use the plural form for units. Consider changing 'In second' to 'In…

_{Review effort: Lite}