Conversation
…mportVM. findByID will fail for dummy template as it is stored in the deleted state.
14 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.22 #14195 +/- ##
=========================================
Coverage 17.97% 17.98%
- Complexity 16184 16186 +2
=========================================
Files 5930 5930
Lines 535615 535614 -1
Branches 65582 65582
=========================================
+ Hits 96271 96304 +33
+ Misses 428377 428336 -41
- Partials 10967 10974 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
weizhouapache
approved these changes
Sep 17, 2026
weizhouapache
left a comment
Member
There was a problem hiding this comment.
code lgtm
need re-testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the
Unable to find template with id 202 for virtual machine importerror thrown when importing a VM.The dummy template
VM Import Default Templateis stored in the removed state, so findById returns null and importVM fails.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Tested ImportVmCmd with and without the fix
How did you try to break this feature and the system with this change?