Repository navigation
Implement occursCountKind="stopValue" - #1728
Open
jadams-tresys wants to merge 9 commits into
Open
jadams-tresys wants to merge 9 commits into
jadams-tresys wants to merge 9 commits into
Conversation
olabusayoT
reviewed
Sep 30, 2026
olabusayoT
left a comment
olabusayoT
left a comment
Contributor
There was a problem hiding this comment.
Some comments about style.
olabusayoT
reviewed
Oct 14, 2026
Comment on lines
+249
to
+255
| <!-- | ||
| Codegen backends cannot parse stopValueElement; generating C code for it fails with | ||
| "Code generation not supported for: RepOrderedStopValueSequenceChild" | ||
|
|
||
| daffodil generate c -r stopValueElement -s variablelen.dfdl.xsd | ||
| --> | ||
|
|
Contributor
There was a problem hiding this comment.
It looks pretty straightfoward to add the ReoOrderedStopValueSequenceChild support to the C generator, any reason why we're not doing this?
added 9 commits
October 19, 2026 07:48
For now only implemented parse support
Also remove some unused test files
One of the requirements in the DFDL spec is that if a stopValue shows up in the infoset, it should result in a processing error.
- ParticleMixin: restore LV(Symbol(...)) for hasStopValue; cook dfdl:occursStopValue separately for parsing and unparsing - SequenceChild: use if/else instead of matching on a boolean - SeparatedSequenceParsers: comment explaining why checkParseAttemptStatus is applied after the separator has been parsed - Remove DAFFODIL-501 from source comments and shorten long ones - Clarify in the variablelen test files that only the Daffodil runtime, not the C code generator, supports stopValue
jadams-tresys
force-pushed
the
DAFFODIL-501
branch
from
October 19, 2026 12:46
583716d to
6a0ff59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bulk of this was done with AI. I tried to give it a thorough review and cleaned up a few things that seemed at odds with our usual coding style (see commit bf40370) but I'll admit I'm not super familiar with all the parts of Daffodil that were involved in this change.
Test coverage seems pretty good, but I think a few more need to be added to verify the various SDE/ProcessingError conditions outlined in the spec. I will add those soon, but wanted to get this up for review to make sure things are headed in the right direction.
DAFFODIL-501