Skip to content

Move offHeap enabled check #2882

Closed
Closed
Move offHeap enabled check#2882
Labels
enhancementNew feature or request

Description

@andygrove
andygrove
opened on Dec 11, 2025

What is the problem the feature request solves?

If users enable Comet with by adding CometSparkSessionExtensions as a Spark extension instead of using the Comet SQL plugin then the offHeap enabled check does not run.

Describe the potential solution

Move the check to CometSparkSessionExtensions or even CometExecRule ?

Additional context

No response

Activity

  1. andygrove
    added this to the 0.13.0 milestone on Dec 11, 2025
  2. andygrove
    added
    enhancementNew feature or request
    on Dec 11, 2025
  3. andygrove
    modified the milestones: 0.13.0, 0.14.0 on Jan 30, 2026
  4. andygrove
    removed this from the 0.14.0 milestone on Mar 12, 2026

  5. andygrove commented on Sep 26, 2026

    @andygrove
    andygrove
    on Sep 26, 2026
    MemberAuthor

    Fixed by #6195. CometSparkSessionExtensions now makes the off-heap check itself, so an application that registers the extension without the plugin no longer runs Comet on-heap unless spark.comet.exec.onHeap.enabled is set. #6186, which #6195 closed, was a later duplicate of this.

  6. andygrove
    closed this as completedon Sep 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions