aggregate blocked impl - #24928
Draft
rluvaton wants to merge 80 commits into
Draft
Conversation
…so all usages will be migrated
…ockedGroupColumn`
…e grouped_hash_stream code
# Conflicts: # datafusion/expr-common/src/groups_accumulator.rs
Member
Author
|
run benchmark external_aggr h2o_medium tpch10 |
Member
Author
|
run benchmarks |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing add-blocks-impl-from-scratch (b939adc) to 4048898 (merge-base) diff Run configurationrun benchmark h2o_mediumResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing add-blocks-impl-from-scratch (b939adc) to 4048898 (merge-base) diff Run configurationrun benchmark tpch10Results will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing add-blocks-impl-from-scratch (b939adc) to 4048898 (merge-base) diff Run configurationrun benchmark clickbench_partitionedResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing add-blocks-impl-from-scratch (b939adc) to 4048898 (merge-base) diff Run configurationrun benchmark tpchResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing add-blocks-impl-from-scratch (b939adc) to 4048898 (merge-base) diff Run configurationrun benchmark external_aggrResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing add-blocks-impl-from-scratch (b939adc) to 4048898 (merge-base) diff Run configurationrun benchmark tpcdsResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing add-blocks-impl-from-scratch (b939adc) to 4048898 (merge-base) diff Run configurationrun benchmark tpchCPU Details (lscpu)Details
Resource Usagetpch — base (merge-base)
tpch — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing add-blocks-impl-from-scratch (b939adc) to 4048898 (merge-base) diff Run configurationrun benchmark tpch10CPU Details (lscpu)Details
Resource Usagetpch10 — base (merge-base)
tpch10 — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing add-blocks-impl-from-scratch (b939adc) to 4048898 (merge-base) diff Run configurationrun benchmark tpcdsCPU Details (lscpu)Details
Resource Usagetpcds — base (merge-base)
tpcds — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing add-blocks-impl-from-scratch (b939adc) to 4048898 (merge-base) diff Run configurationrun benchmark clickbench_partitionedCPU Details (lscpu)Details
Resource Usageclickbench_partitioned — base (merge-base)
clickbench_partitioned — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing add-blocks-impl-from-scratch (b939adc) to 4048898 (merge-base) diff Run configurationrun benchmark h2o_mediumCPU Details (lscpu)Details
Resource Usageh2o_medium — base (merge-base)
h2o_medium — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing add-blocks-impl-from-scratch (b939adc) to 4048898 (merge-base) diff Run configurationrun benchmark external_aggrCPU Details (lscpu)Details
Memory Pool PeaksPeak Base:
Pool accounting vs. process RSS Max pool peak is the largest reservation any single query in the run reached; peak RSS covers the whole invocation, including data loading and allocator retention, and the two high-water marks need not coincide in time. The gap is therefore an upper bound on what the pool did not account for, not a measurement of it.
Resource Usageexternal_aggr — base (merge-base)
external_aggr — branch
File an issue against this benchmark runner |
``` mmap vs VecDeque (branch/main medians, same box, same day) ┌──────────────────────────────────┬──────────────────────────────────┬──────────────────────────────────┐ │ │ mmap + pool │ VecDeque │ ├──────────────────────────────────┼──────────────────────────────────┼──────────────────────────────────┤ │ TPC-DS Q1 / Q43 / Q36 / Q27 │ 1.02 / 1.09 / 0.96 / 1.02 │ 1.06 / 0.98 / 1.04 / 1.05 │ ├──────────────────────────────────┼──────────────────────────────────┼──────────────────────────────────┤ │ TPC-DS Q76 / Q81 / Q23 / Q39 │ 1.09 / 1.05 / 1.14 / 1.10 │ 1.03 / 1.02 / 1.08 / 1.07 │ ├──────────────────────────────────┼──────────────────────────────────┼──────────────────────────────────┤ │ TPC-DS Q11 / Q57 / others │ 1.07 / 1.10 / 1.00–1.06 │ 1.07 / 1.07 / 0.99–1.03 │ ├──────────────────────────────────┼──────────────────────────────────┼──────────────────────────────────┤ │ external_aggr Q1 (64/32/16 MB) │ 1.19 / 1.08 / 1.05 │ 1.22 / 1.12 / 1.13 │ ├──────────────────────────────────┼──────────────────────────────────┼──────────────────────────────────┤ │ external_aggr Q2 (512…32 MB) │ 1.03 / 0.99 / 1.07 / 1.06 / 1.09 │ 1.05 / 0.94 / 1.08 / 1.07 / 1.04 │ ├──────────────────────────────────┼──────────────────────────────────┼──────────────────────────────────┤ │ ClickBench Q33 / Q16 / Q18 / Q32 │ 1.02 / 1.11 / 0.87 / ~1.05 │ 1.17 / 1.09 / 1.10 / 1.07 │ └──────────────────────────────────┴──────────────────────────────────┴──────────────────────────────────┘ So: VecDeque wins on TPC-DS (mid-size aggregations, less setup and teardown), loses clearly on the big single-column string aggregations. Q33's profile shows why: GroupValuesBytesView::intern +24% and BlockedCount::update_batch +53%, from the two-level lookup (VecDeque slot → Vec → element) on every row versus one flat offset with mmap. ```
Member
Author
|
run benchmark external_aggr h2o_medium tpch10 |
Member
Author
|
run benchmarks |
|
Benchmark for this request failed before finishing (Kubernetes reason: Benchmarks requested: Runner log (last 40 lines)Kubernetes messageFile an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing add-blocks-impl-from-scratch (78834e5) to 4048898 (merge-base) diff Run configurationrun benchmark clickbench_partitionedResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing add-blocks-impl-from-scratch (78834e5) to 4048898 (merge-base) diff Run configurationrun benchmark external_aggrResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing add-blocks-impl-from-scratch (78834e5) to 4048898 (merge-base) diff Run configurationrun benchmark tpcdsResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing add-blocks-impl-from-scratch (78834e5) to 4048898 (merge-base) diff Run configurationrun benchmark tpchResults will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing add-blocks-impl-from-scratch (78834e5) to 4048898 (merge-base) diff Run configurationrun benchmark tpch10Results will be posted here when complete File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing add-blocks-impl-from-scratch (78834e5) to 4048898 (merge-base) diff Run configurationrun benchmark tpchCPU Details (lscpu)Details
Resource Usagetpch — base (merge-base)
tpch — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing add-blocks-impl-from-scratch (78834e5) to 4048898 (merge-base) diff Run configurationrun benchmark tpch10CPU Details (lscpu)Details
Resource Usagetpch10 — base (merge-base)
tpch10 — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing add-blocks-impl-from-scratch (78834e5) to 4048898 (merge-base) diff Run configurationrun benchmark tpcdsCPU Details (lscpu)Details
Resource Usagetpcds — base (merge-base)
tpcds — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing add-blocks-impl-from-scratch (78834e5) to 4048898 (merge-base) diff Run configurationrun benchmark clickbench_partitionedCPU Details (lscpu)Details
Resource Usageclickbench_partitioned — base (merge-base)
clickbench_partitioned — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: Comparing add-blocks-impl-from-scratch (78834e5) to 4048898 (merge-base) diff Run configurationrun benchmark external_aggrCPU Details (lscpu)Details
Memory Pool PeaksPeak Base:
Pool accounting vs. process RSS Max pool peak is the largest reservation any single query in the run reached; peak RSS covers the whole invocation, including data loading and allocator retention, and the two high-water marks need not coincide in time. The gap is therefore an upper bound on what the pool did not account for, not a measurement of it.
Resource Usageexternal_aggr — base (merge-base)
external_aggr — branch
File an issue against this benchmark runner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Huge blocked impl that is backwards compatible
And just see the performance cost
Currently it only contain blocked impl for single group by and some aggregate expression
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
What is the testing strategy for this PR?
Are there any user-facing changes?