Skip to content

fix: treat escaped percent as a literal - #1115

Merged
bengbengbalabalabeng merged 7 commits into
apache:mainfrom
nkuprins:fix/escaped-percent-literal
Oct 15, 2026
Merged

bengbengbalabalabeng merged 7 commits into
apache:mainfrom
nkuprins:fix/escaped-percent-literal

Conversation

@nkuprins

@nkuprins nkuprins commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Closed: #1114

Purpose of the pull request

As title

What's changed?

  • Fixes escaped-percent number formats so % displays a per cent sign without scaling the value.
  • Adds a parameterised test pinning the fix.

Checklist

  • I have read the Contributor Guide.
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@nkuprins
nkuprins marked this pull request as ready for review October 10, 2026 08:25
# Conflicts:
#	fesod-sheet/src/test/java/org/apache/fesod/sheet/metadata/format/DataFormatterTest.java
@nkuprins
nkuprins force-pushed the fix/escaped-percent-literal branch from 444fb2c to c24ea8c Compare October 10, 2026 08:28
nkuprins and others added 3 commits October 15, 2026 11:53

@bengbengbalabalabeng bengbengbalabalabeng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bengbengbalabalabeng
bengbengbalabalabeng merged commit afc959b into apache:main Oct 15, 2026
9 checks passed
@nkuprins
nkuprins deleted the fix/escaped-percent-literal branch October 15, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Escaped percent in a number format (0\%) multiplies the value by 100 when reading

2 participants