Skip to content

fix: render negative date serials as numbers - #1117

Merged
bengbengbalabalabeng merged 5 commits into
apache:mainfrom
nkuprins:fix/negative-serial-date-format
Oct 15, 2026
Merged

bengbengbalabalabeng merged 5 commits into
apache:mainfrom
nkuprins:fix/negative-serial-date-format

Conversation

@nkuprins

@nkuprins nkuprins commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Closed: #1116

Purpose of the pull request

As title.

What's changed?

  • Negative Excel date serials now fall back to general number formatting instead of throwing.
  • Adds a parameterised test pinning the fix.

Checklist

  • I have read the Contributor Guide.
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

…ormat

# Conflicts:
#	fesod-sheet/src/test/java/org/apache/fesod/sheet/metadata/format/DataFormatterTest.java
@nkuprins
nkuprins marked this pull request as ready for review October 10, 2026 09:17

@bengbengbalabalabeng bengbengbalabalabeng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bengbengbalabalabeng
bengbengbalabalabeng merged commit 2e606a5 into apache:main Oct 15, 2026
9 checks passed
@nkuprins
nkuprins deleted the fix/negative-serial-date-format branch October 15, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Negative value in a date format aborts the read with ExcelDataConvertException

2 participants