Repository navigation
Fix missing Spring and OW2 attributions in shaded JAR - #1176
skytin1004 wants to merge 3 commits into
Conversation
|
I did another pass through the repository and found one additional copy of the ASM license in dist/licenses/LICENSE-asm.txt, which is included in the source release. I've added the missing OW2 attribution there as well. I also rebuilt the release artifacts and confirmed the updated license and notice files are included. I didn’t find any other missing copies. |
70bd704 to
989e479
Compare
| The Apache Software Foundation (http://www.apache.org/). | ||
| ----------------------------------------------------------------------- | ||
| This product includes software developed by the Spring Framework Project (https://spring.io). | ||
| Copyright (c) 2002-2024 Pivotal, Inc. |
There was a problem hiding this comment.
better to have
Spring Framework 5.3.39
Copyright (c) 2002-2024 Pivotal, Inc.
This is in #1172 description
|
Thanks @skytin1004. After looking into it further, I think we should drop the OW2 Consortium line and keep only the NOTICE change. The OW2 line looks like something unusual that Spring added rather than something ASM requires:
More detail is in #1172 (comment). Could you revert the changes to |
Purpose of the pull request
Closed: #1172
Add the missing copyright attribution for the Spring and ASM code bundled in
fesod-shaded, and keep the standalone ASM license used by the source distribution consistent.What's changed?
fesod-shaded'sMETA-INF/NOTICE.fesod-shaded'sMETA-INF/LICENSE.dist/licenses/LICENSE-asm.txt, which is included in the source release ZIP.spring-core5.3.39 license and preserved the existing LF/EOF style.Validation
./mvnw clean package -Papache-release -DskipTests -Dgpg.skip=true.spring-core5.3.39, with no Objenesis or unexpected third-party classes.git diff --checkand verified all three changed files use LF line endings.Checklist