HBASE-30382: Update zstd-jni to 1.5.7-20 - #8652
Conversation
f526909 to
69fc617
Compare
|
I guess this is Flakes test fail ? Can anyone help me here ? |
Good question. Unfortunately sometimes there are flakey tests. If you open the failing check and click on the Summary tab then you can see which tests failed. |
|
Hi @PDavid, thanks for looking into this. I ran all 35 failing tests locally on this branch (JDK17, matching CI) and they all pass — confirms these are pre-existing flaky tests, unrelated to the zstd-jni bump. see here : |
PDavid
left a comment
There was a problem hiding this comment.
Many thanks, looks good to me. 👍
|
ping @liuxiaocs7 , can you review it , and the failed piplines in the other branches PR ( what I see that the failed test are not related to this change) . |
69fc617 to
5329c0f
Compare
|
I'll merge this once the PR test jobs are completed. |
|
these failures are not related to this changes. |
Signed-off-by: Dávid Paksy <paksyd@apache.org> Signed-off-by: Peter Somogyi <psomogyi@apache.com> (cherry picked from commit febef27)
Signed-off-by: Dávid Paksy <paksyd@apache.org> Signed-off-by: Peter Somogyi <psomogyi@apache.com> (cherry picked from commit febef27)
Signed-off-by: Dávid Paksy <paksyd@apache.org> Signed-off-by: Peter Somogyi <psomogyi@apache.com> (cherry picked from commit febef27)
Signed-off-by: Dávid Paksy <paksyd@apache.org> Signed-off-by: Peter Somogyi <psomogyi@apache.com> (cherry picked from commit febef27)
Signed-off-by: Dávid Paksy <paksyd@apache.org> Signed-off-by: Peter Somogyi <psomogyi@apache.com> (cherry picked from commit febef27)
|
Sorry for the late reply, thanks @arvindKandpal-ksolves! |
What changes were proposed in this pull request?
Bumps zstd-jni from 1.5.7-2 to 1.5.7-20 in the root pom.xml.
Why are the changes needed?
zstd-jni versions prior to 1.5.7-14 contain vulnerable code addressed by:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Ran the full zstd-jni compression test suite before and after the bump:
TestWALCompressionZstd, TestZstdCodec, TestHFileCompressionZstd,
TestZstdDictionary, TestZstdDictionarySplitMerge, TestZstdByteBuffDecompressor.
Baseline (1.5.7-2): 15 tests run, 0 failures, 0 errors
After bump (1.5.7-15): 15 tests run, 0 failures, 0 errors
Also verified via
mvn dependency:treethat the resolved artifact iscom.github.luben:zstd-jni:jar:1.5.7-15.