Skip to content

HIVE-30034: Add TPCDS planner tests for Iceberg tables - #6781

Open
zabetak wants to merge 10 commits into
apache:masterfrom
zabetak:HIVE-30034_02
Open

zabetak wants to merge 10 commits into
apache:masterfrom
zabetak:HIVE-30034_02

Conversation

@zabetak

@zabetak zabetak commented Sep 14, 2026

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

  • Add TPCDS planner tests for Iceberg tables backed by S3 container
  • Add S3Container using rustfs for tests that need s3a:// access
  • Add test driver, init script, and expected output files for all 99 TPCDS queries

Why are the changes needed?

For catching performance and functionality regressions of the query planner for Iceberg tables.

Does this PR introduce any user-facing change?

No

How was this patch tested?

mvn test -Dtest=TestTPCDSIcebergCliDriver

@zabetak

zabetak commented Sep 16, 2026

Copy link
Copy Markdown
Member Author

Comment thread itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java Outdated
setCleanupScript("q_test_cleanup_tez.sql");
S3Container.BucketSpec bucketSpec = new S3Container.BucketSpec(
"dw-team-bucket/data/warehouse/tablespace/external/hive/tpcds_partitioned_iceberg_parquet_10000.db",
"https://github.com/zabetak/hive-test-datasets/releases/download/1.1/iceberg_s3_tpcds10tb.zip");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it ok to have a personal repo here?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the moment yes! My personal repo is also used in: standalone-metastore/metastore-server/docker/hive-postgres-tpcds-metastore/Dockerfile

Once I find time, I will try to migrate those to the apache namespace as per discussion: https://lists.apache.org/thread/wdmnhk1tg42vxbpsjz1jc309l2shmr23

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I migrated the datasets to the ASF namespace and added checksum verification on download: dd972f6

Comment thread itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java Outdated
Comment thread itests/util/src/main/java/org/apache/hadoop/hive/cli/S3Container.java Outdated
Comment thread itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestArguments.java Outdated
Comment thread itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestMiniClusters.java Outdated
Comment thread itests/util/src/main/java/org/apache/hadoop/hive/cli/S3Container.java Outdated
Comment thread itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java Outdated
- Add TPCDS planner tests for Iceberg tables backed by S3 container
- Add S3Container using rustfs for tests that need s3a:// access
- Add test driver, init script, and expected output files for all 99 TPCDS queries
Even if the tmp file is not deleted by the JVM it will be cleaned during the maven clean lifecycle.
@sonarqubecloud

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants