Repository navigation
HIVE-30067:Include json-simple in hive-exec shaded jar for JTS GeoJSON - #6797
Merged
Merged
Conversation
Change-Id: I53bdf527a3ec05926885807391c30a89d46c7d73
asf-ci-hive
added
tests pending
tests unstable
and removed
tests pending
tests unstable
labels
ramitg254
changed the title
|
abstractdog
approved these changes
Oct 2, 2026
abstractdog
left a comment
abstractdog
left a comment
Contributor
There was a problem hiding this comment.
change makes sense to me, jts is already shaded, so its direct dependenct json-simple should also go to the artifact to prevent later classpath problems
without relocation, another kind of classpath problems can happen, but we should assume in the first place that non-relocated artifacts are fine, and we can take care of it later in case we face any problems
+1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: I53bdf527a3ec05926885807391c30a89d46c7d73
What changes were proposed in this pull request?
Include json-simple in hive-exec shaded jar for JTS GeoJSON
Why are the changes needed?
explained here in detail https://issues.apache.org/jira/browse/HIVE-30067
Does this PR introduce any user-facing change?
No
How was this patch tested?
locally