Skip to content

[ssh] Support ed25519 keys using bouncycastle (backport #2927) - #2977

Closed
jbonofre wants to merge 1 commit into
apache:karaf-4.4.xfrom
jbonofre:backport-2927-karaf-4.4.x
Closed

jbonofre wants to merge 1 commit into
apache:karaf-4.4.xfrom
jbonofre:backport-2927-karaf-4.4.x

Conversation

@jbonofre

@jbonofre jbonofre commented Oct 6, 2026

Copy link
Copy Markdown
Member

Backport of #2927 to karaf-4.4.x.

Enable ssh-ed25519 in the default signature algorithms, match ed25519 keys in the publickey login module, and add the bouncycastle jars from the distribution to the bin/client classpath.

The cherry-pick applied cleanly. PublicKeyEncodingTest in jaas/modules passes.

Not covered (same as the original PR): keys with password and hardware keys (sk-...).

Enable ssh-ed25519 in the default signature algorithms, match ed25519
keys in the publickey login module, and add the bouncycastle jars from
the distribution to the bin/client classpath.

(cherry picked from commit f7d9d4a)
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

Test Results

  264 files   -   408    264 suites   - 408   3m 32s ⏱️ - 59m 29s
  421 tests  -   613    408 ✅  -   583  12 💤  - 31  0 ❌ ±0  1 🔥 +1 
1 263 runs   - 1 567  1 224 ✅  - 1 486  36 💤  - 84  0 ❌ ±0  3 🔥 +3 

For more details on these errors, see this check.

Results for commit 46d0f14. ± Comparison against base commit 9559568.

This pull request removes 614 and adds 1 tests. Note that renamed tests count towards both.
org.apache.karaf.audit.TestPerf ‑ Unknown test
org.apache.karaf.audit.logger.EventLoggerTest ‑ testFile
org.apache.karaf.audit.logger.EventLoggerTest ‑ testFileMaxFiles
org.apache.karaf.audit.logger.EventLoggerTest ‑ testFileSize
org.apache.karaf.audit.logger.EventLoggerTest ‑ testFileSizeCompress
org.apache.karaf.audit.logger.EventLoggerTest ‑ testTcp
org.apache.karaf.audit.logger.EventLoggerTest ‑ testUdp
org.apache.karaf.audit.util.FastDateFormatTest ‑ test
org.apache.karaf.audit.util.FastDateFormatTest ‑ testTimeZone
org.apache.karaf.bundle.command.ListServicesTest ‑ listAllLong
…
org.apache.karaf.jaas.modules.publickey.PublicKeyEncodingTest ‑ testEd25519

@jbonofre

jbonofre commented Oct 6, 2026

Copy link
Copy Markdown
Member Author

This PR is actually not needed as it's still Java 11.

@jbonofre jbonofre closed this Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants