fix(skill-evals): security eval fixtures that failed correct answers, and the triage suite's old taxonomy - #1468
Merged
Conversation
… and the triage suite's old taxonomy Fixture fixes, each checked against the case input: - issue-fix 5b case 3 expected a description endorsing an injected `BYPASS_AUTH = True` snippet the model rightly rejects. - issue-fix 5c case 3 expected both `security fix` and an overlapping bare `security`. - issue-fix 5g asked for "forbidden strings" but graded occurrences; the spec now asks for each occurrence as it appears. - invalidate step 4 graded the open-ended `other_applicable` list against `[]`; it is no longer graded. The selected section still is. - import 2b: the spec says when `reporter_followup_summary` is null and asks for the `#NNN` form of the ref. - import 5: the spec says `canned_response_name` is null for an imported report. - cve-allocate step 1 case 2 has two hard blockers in its input; the expected answer now lists both. - cve-allocate step 2: the spec says how to count words. - forwarder step 1: `preamble_snippet` is the matched text up to its first line break, instead of a length-varying "~80 characters". The security-issue-triage suite still used the old five-class taxonomy (NOT-CVE-WORTHY). It now uses the skill's six classes (INVALID, FIX-ALREADY-PUBLIC added), in the system prompts, expectations, distribution keys and README. The label and heading text "not CVE worthy" is unchanged. Generated-by: Claude Code (Opus 5.5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from the security-family optimization (#1344): eval fixtures that failed correct answers, and the triage suite's outdated taxonomy.
Fixture fixes
BYPASS_AUTH = Truesnippet, which the model rightly rejectssecurity fixand an overlapping baresecurityother_applicablelist against[]#NNNvs URL#NNNTriage suite taxonomy
The security-issue-triage suite still used the old five-class set (NOT-CVE-WORTHY). It now uses the skill's six classes, INVALID plus the added FIX-ALREADY-PUBLIC, across 28 files: system prompts, expectations,
distributionkeys, the step-2.6 signal enum and the README. The label and heading text "not CVE worthy" is unchanged, and fixture directories keep their names.Test plan
main. They predate this change and are left for a separate look.Part of #1344.
Generated-by: Claude Code (Opus 5.5)
🤖 Generated with Claude Code