Repository navigation
Conversation
rich7420
marked this pull request as draft
October 2, 2026 15:01
rich7420
marked this pull request as ready for review
October 3, 2026 08:40
chungen0126
reviewed
Oct 14, 2026
chungen0126
left a comment
Contributor
There was a problem hiding this comment.
Thanks @rich7420 for working on this.
Instead of reusing GET_FILE_STATUS_REJECTS_OBS to gate derived-key requests, I suggest introducing a dedicated new OzoneManagerVersion.
There is no need to reuse existing versions here. Defining an explicit, dedicated version makes it much clearer to everyone what capability each OM version represents and why it was introduced, which will also make future version checks and maintenance much more readable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a dedicated
S3_DERIVED_KEYOM version and gate derived-key requests across key and multipart writes. In secure mode, S3 Gateway returnsNotImplementedbefore opening a key when the connected OM does not support chunk verification. A supporting OM that returns no derived key still fails withInternalError.The capability is placed before
ZDU, since derived keys are available before upgrade finalization. This preserves signed uploads on upgraded, unfinalized clusters.What is the link to the Apache JIRA?
https://issues.apache.org/jira/browse/HDDS-16358
How was this patch tested?
With JDK 21 on the final Java changes:
TestOMUpgradeFinalization#testServiceInfoOmVersionTracksClientVersionpassed on a three-OM HA cluster, checking the advertised version before and after finalization.Latest fork CI is running. The previous 10×10 runs cover the earlier implementation; repeat checks on this updated head are still pending.
Generated-by: Codex (GPT-6)